From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter Xu <peterx@redhat.com>
Subject: Re: [PATCH kvm-unit-tests v6 11/14] pci: edu: introduce pci-edu
 helpers
Date: Mon, 28 Nov 2016 13:36:34 +0800
Message-ID: <20161128053634.GA9585@pxdev.xzpeter.org>
References: <1479898654-7707-1-git-send-email-peterx@redhat.com>
 <1479898654-7707-12-git-send-email-peterx@redhat.com>
 <20161127105446.GB14381@agordeev.lab.eng.brq.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Cc: kvm@vger.kernel.org, drjones@redhat.com, jan.kiszka@web.de,
        rkrcmar@redhat.com, pbonzini@redhat.com
To: Alexander Gordeev <agordeev@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:48436 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751725AbcK1Fgk (ORCPT <rfc822;kvm@vger.kernel.org>);
        Mon, 28 Nov 2016 00:36:40 -0500
Content-Disposition: inline
In-Reply-To: <20161127105446.GB14381@agordeev.lab.eng.brq.redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Sun, Nov 27, 2016 at 11:54:46AM +0100, Alexander Gordeev wrote:
> On Wed, Nov 23, 2016 at 06:57:31PM +0800, Peter Xu wrote:
> > +void edu_dma(struct pci_edu_dev *dev, iova_t iova,
> > +	     size_t size, int dev_offset, bool from_device)
> > +{
> > +	uint64_t from, to;
> > +	uint32_t cmd = EDU_CMD_DMA_START;
> > +
> > +	assert(size <= EDU_DMA_SIZE_MAX);
> > +	assert(dev_offset < EDU_DMA_SIZE_MAX &&
> > +	       dev_offset >= 0);
> 
> Any reason for dev_offset not to be unsigned?

No specific reason (though logically it can be <0 value, since it'll
be by default shifted by EDU_DMA_START later). I can switch to
unsigned if there is any further repost. Thanks,

-- peterx