From: Roman Kagan <rkagan@virtuozzo.com>
To: "Radim Krčmář" <rkrcmar@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
kvm@vger.kernel.org
Cc: Denis Lunev <den@virtuozzo.com>, Roman Kagan <rkagan@virtuozzo.com>
Subject: [PATCH 4/5] kvm/vmx: kick L2 guest to L1 by ready async_pf
Date: Fri, 2 Dec 2016 11:47:53 +0300 [thread overview]
Message-ID: <20161202084754.22860-5-rkagan@virtuozzo.com> (raw)
In-Reply-To: <20161202084754.22860-1-rkagan@virtuozzo.com>
When async pagefault is resolved vCPU may be executing L2 guest.
In order to allow L1 take better scheduling decisions in such cases,
make L2 exit to L1 on a fake external interupt, without actually
injecting it (unless L2 has other reasons to vmexit).
This patch does that for x86/Intel.
Signed-off-by: Roman Kagan <rkagan@virtuozzo.com>
---
arch/x86/kvm/vmx.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index 5382b82..fc97489 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -10420,7 +10420,8 @@ static int vmx_check_nested_events(struct kvm_vcpu *vcpu, bool external_intr)
return 0;
}
- if ((kvm_cpu_has_interrupt(vcpu) || external_intr) &&
+ if ((kvm_cpu_has_interrupt(vcpu) || external_intr ||
+ kvm_async_pf_has_ready(vcpu)) &&
nested_exit_on_intr(vcpu)) {
if (vmx->nested.nested_run_pending)
return -EBUSY;
@@ -10772,9 +10773,9 @@ static void nested_vmx_vmexit(struct kvm_vcpu *vcpu, u32 exit_reason,
if ((exit_reason == EXIT_REASON_EXTERNAL_INTERRUPT)
&& nested_exit_intr_ack_set(vcpu)) {
int irq = kvm_cpu_get_interrupt(vcpu);
- WARN_ON(irq < 0);
- vmcs12->vm_exit_intr_info = irq |
- INTR_INFO_VALID_MASK | INTR_TYPE_EXT_INTR;
+ if (irq >= 0)
+ vmcs12->vm_exit_intr_info = irq |
+ INTR_INFO_VALID_MASK | INTR_TYPE_EXT_INTR;
}
trace_kvm_nested_vmexit_inject(vmcs12->vm_exit_reason,
--
2.9.3
next prev parent reply other threads:[~2016-12-02 8:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 8:47 [PATCH 0/5] kvm: avoid delaying async_pf ready delivery Roman Kagan
2016-12-02 8:47 ` [PATCH 1/5] kvm/x86: fix inversed check for async_pf MSR Roman Kagan
2016-12-02 8:47 ` [PATCH 2/5] kvm: add helper for testing ready async_pf's Roman Kagan
2016-12-02 8:47 ` [PATCH 3/5] kvm: kick vcpu when async_pf is resolved Roman Kagan
2016-12-02 9:35 ` Christian Borntraeger
2016-12-02 9:40 ` Paolo Bonzini
2016-12-02 10:00 ` Christian Borntraeger
2016-12-02 11:34 ` Roman Kagan
2016-12-05 8:08 ` Christian Borntraeger
2016-12-02 11:28 ` Roman Kagan
2016-12-03 4:02 ` kbuild test robot
2016-12-06 11:05 ` kbuild test robot
2016-12-02 8:47 ` Roman Kagan [this message]
2016-12-02 8:47 ` [PATCH 5/5] kvm/svm: kick L2 guest to L1 by ready async_pf Roman Kagan
2016-12-02 9:35 ` Paolo Bonzini
2016-12-02 12:33 ` Roman Kagan
2016-12-12 12:40 ` Roman Kagan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161202084754.22860-5-rkagan@virtuozzo.com \
--to=rkagan@virtuozzo.com \
--cc=den@virtuozzo.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox