From: Eduardo Habkost <ehabkost@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org,
Dr David Alan Gilbert <dgilbert@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Juan Quintela <quintela@redhat.com>,
Radim Krcmar <rkrcmar@redhat.com>
Subject: Re: [qemu patch V4 2/2] kvmclock: reduce kvmclock difference on migration
Date: Mon, 12 Dec 2016 16:01:05 -0200 [thread overview]
Message-ID: <20161212180105.GF3808@thinpad.lan.raisama.net> (raw)
In-Reply-To: <20161210172324.482367805@redhat.com>
On Sat, Dec 10, 2016 at 03:21:50PM -0200, Marcelo Tosatti wrote:
[...]
> static void kvmclock_realize(DeviceState *dev, Error **errp)
> {
> KVMClockState *s = KVM_CLOCK(dev);
>
> + if (kvm_has_adjust_clock_stable()) {
> + s->clock_is_reliable = true;
> + }
> +
This seems unnecessary, as kvmclock_vm_state_change() makes sure
it is set at the same time as s->clock. Should we just remove it?
> qemu_add_vm_change_state_handler(kvmclock_vm_state_change, s);
> }
>
[...]
--
Eduardo
next prev parent reply other threads:[~2016-12-12 18:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-10 17:21 [qemu patch V4 0/2] improve kvmclock difference on migration Marcelo Tosatti
2016-12-10 17:21 ` [qemu patch V4 1/2] kvm: sync linux headers Marcelo Tosatti
2016-12-10 17:21 ` [qemu patch V4 2/2] kvmclock: reduce kvmclock difference on migration Marcelo Tosatti
2016-12-12 7:36 ` [Qemu-devel] " Pankaj Gupta
2016-12-12 11:22 ` Marcelo Tosatti
2016-12-12 14:24 ` Pankaj Gupta
2016-12-13 1:32 ` Pankaj Gupta
2016-12-12 18:01 ` Eduardo Habkost [this message]
2016-12-12 19:44 ` Marcelo Tosatti
2016-12-12 19:57 ` Eduardo Habkost
2016-12-16 10:03 ` Paolo Bonzini
2016-12-16 13:41 ` Eduardo Habkost
2016-12-16 15:59 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161212180105.GF3808@thinpad.lan.raisama.net \
--to=ehabkost@redhat.com \
--cc=dgilbert@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox