From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [qemu patch V4 2/2] kvmclock: reduce kvmclock difference on
 migration
Date: Mon, 12 Dec 2016 16:01:05 -0200
Message-ID: <20161212180105.GF3808@thinpad.lan.raisama.net>
References: <20161210172148.361793326@redhat.com>
 <20161210172324.482367805@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org,
        Dr David Alan Gilbert <dgilbert@redhat.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Juan Quintela <quintela@redhat.com>,
        Radim Krcmar <rkrcmar@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:41400 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751465AbcLLSBH (ORCPT <rfc822;kvm@vger.kernel.org>);
        Mon, 12 Dec 2016 13:01:07 -0500
Content-Disposition: inline
In-Reply-To: <20161210172324.482367805@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Sat, Dec 10, 2016 at 03:21:50PM -0200, Marcelo Tosatti wrote:
[...]
>  static void kvmclock_realize(DeviceState *dev, Error **errp)
>  {
>      KVMClockState *s = KVM_CLOCK(dev);
>  
> +    if (kvm_has_adjust_clock_stable()) {
> +        s->clock_is_reliable = true;
> +    }
> +

This seems unnecessary, as kvmclock_vm_state_change() makes sure
it is set at the same time as s->clock. Should we just remove it?

>      qemu_add_vm_change_state_handler(kvmclock_vm_state_change, s);
>  }
>  
[...]

-- 
Eduardo