From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [PATCH kvm-unit-tests v2] Add git-diff orderFile Date: Tue, 13 Dec 2016 17:06:08 +0100 Message-ID: <20161213160607.GB9488@potion> References: <20161212140853.5061-1-drjones@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: kvm@vger.kernel.org, pbonzini@redhat.com, lvivier@redhat.com, thuth@redhat.com To: Andrew Jones Return-path: Received: from mx1.redhat.com ([209.132.183.28]:42284 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932537AbcLMQGL (ORCPT ); Tue, 13 Dec 2016 11:06:11 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 76ADEC05AA59 for ; Tue, 13 Dec 2016 16:06:11 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20161212140853.5061-1-drjones@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: 2016-12-12 15:08+0100, Andrew Jones: > It's helpful to have a common order of file types in patches. > Applying git-diff's orderFile feature allows us to do that. Just > do 'git config diff.orderFile scripts/git.difforder' to enable it. > > Signed-off-by: Andrew Jones > --- > v2 changed the file name and forces common (lib/) before unit > test code. Rearranged some other stuff too; now the approach > is docs, running, building, common-lib/arch-lib (can't force > common-lib to be first), unit-test, unittests.cfg, and, as > much as possible, helpers before users and headers before code. Acked-by: Radim Krčmář (While burning the pile of review notes I prepared for v2 through v9; v9 would ask for a checkpatch script to verify the order. ;])