From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [PATCH v2 2/6] KVM: x86: decouple irqchip_in_kernel() and pic_irqchip() Date: Fri, 16 Dec 2016 16:44:05 +0100 Message-ID: <20161216154404.GA3637@potion> References: <20161216151006.11776-1-rkrcmar@redhat.com> <20161216151006.11776-3-rkrcmar@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org To: Paolo Bonzini Return-path: Received: from mx1.redhat.com ([209.132.183.28]:50218 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754718AbcLPPoI (ORCPT ); Fri, 16 Dec 2016 10:44:08 -0500 Content-Disposition: inline In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: 2016-12-16 16:25+0100, Paolo Bonzini: > On 16/12/2016 16:10, Radim Krčmář wrote: >> + bool ret = irqchip_kernel(kvm) || irqchip_split(kvm); > > bool ret = (kvm->arch.irqchip_mode != KVM_IRQCHIP_NONE); > > :) (That imposes an assumption that we will only add in-kernel irqchips! Are we willing to sell our souls for faster code? :]) I'll use that line without parentheses, thanks.