Re: [PATCH 2/2] KVM: x86: flush pending lapic jump label updates on module unload

Radim Krčmář
2016-12-19T14:24:05Z

2016-12-16 14:30-0800, David Matlack:
> KVM's lapic emulation uses static_key_deferred (apic_{hw,sw}_disabled).
> These are implemented with delayed_work structs which can still be
> pending when the KVM module is unloaded. We've seen this cause kernel
> panics when the kvm_intel module is quickly reloaded.
>
> Use the new static_key_deferred_flush() API to flush pending updates on
> module unload.
>
> Signed-off-by: David Matlack <dmatlack@google.com>
> ---

Oh, this forgotten bug. I guess that patches to do this automatically
from generic module unload code would be over-engineering it ...

Reviewed-by: Radim Krčmář <rkrcmar@redhat.com>

Thanks.