From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, David Hildenbrand <david@redhat.com>
Subject: Re: [kvm-unit-tests PATCH] x86: apic: add physical broadcast test
Date: Thu, 22 Dec 2016 19:15:27 +0100 [thread overview]
Message-ID: <20161222181526.GA25692@potion> (raw)
In-Reply-To: <3dc9431f-a51f-f5bc-69f3-12df2998c9dd@redhat.com>
2016-12-22 11:45+0100, Paolo Bonzini:
> On 19/12/2016 17:04, Radim Krčmář wrote:
>> Broadcast to address 0xff is not exercised by seabios+linux so we better
>> test it.
>>
>> Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
>> ---
>
> This test is broken by
>
> commit f11e8b051ef613670f9db77a79726534dbc667ec
> Author: Radim Krčmář <rkrcmar@redhat.com>
> Date: Tue Dec 13 17:30:00 2016 +0100
>
> KVM: x86: make interrupt delivery fast and slow path behave the same
>
> Slow path tried to prevent IPIs from x2APIC VCPUs from being delivered
> to xAPIC VCPUs and vice-versa. Make slow path behave like fast path,
> which never distinguished that.
>
> Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
> Fixes: 682f732ecf73 ("KVM: x86: bump MAX_VCPUS to 288")
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>
> when run with "./x86/run x86/apic.flat -smp 2 -cpu Nehalem,-x2apic", so I'm removing
> that series from kvm/queue.
Yes, kvm/queue had v2 of the series and I have added the test because
David noticed the broadcast bug while reviewing v3 of that series.
(http://www.spinics.net/lists/kvm/msg142614.html)
The bug was fixed in v4. I have only posted v4 of this one patch as the
rest seemed ok in v3.
next prev parent reply other threads:[~2016-12-22 18:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-19 16:04 [kvm-unit-tests PATCH] x86: apic: add physical broadcast test Radim Krčmář
2016-12-22 10:02 ` Paolo Bonzini
2016-12-22 18:23 ` Radim Krčmář
2016-12-22 10:45 ` Paolo Bonzini
2016-12-22 18:15 ` Radim Krčmář [this message]
2016-12-22 18:24 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161222181526.GA25692@potion \
--to=rkrcmar@redhat.com \
--cc=david@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox