From mboxrd@z Thu Jan  1 00:00:00 1970
From: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
Subject: Re: [kvm-unit-tests PATCH] x86: apic: add physical broadcast test
Date: Thu, 22 Dec 2016 19:15:27 +0100
Message-ID: <20161222181526.GA25692@potion>
References: <20161219160429.5237-1-rkrcmar@redhat.com>
 <3dc9431f-a51f-f5bc-69f3-12df2998c9dd@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: kvm@vger.kernel.org, David Hildenbrand <david@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:36214 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1758716AbcLVSPa (ORCPT <rfc822;kvm@vger.kernel.org>);
        Thu, 22 Dec 2016 13:15:30 -0500
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mx1.redhat.com (Postfix) with ESMTPS id 267A569CCA
        for <kvm@vger.kernel.org>; Thu, 22 Dec 2016 18:15:30 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <3dc9431f-a51f-f5bc-69f3-12df2998c9dd@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

2016-12-22 11:45+0100, Paolo Bonzini:
> On 19/12/2016 17:04, Radim Krčmář wrote:
>> Broadcast to address 0xff is not exercised by seabios+linux so we better
>> test it.
>> 
>> Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
>> ---
> 
> This test is broken by
> 
>     commit f11e8b051ef613670f9db77a79726534dbc667ec
>     Author: Radim Krčmář <rkrcmar@redhat.com>
>     Date:   Tue Dec 13 17:30:00 2016 +0100
> 
>     KVM: x86: make interrupt delivery fast and slow path behave the same
>     
>     Slow path tried to prevent IPIs from x2APIC VCPUs from being delivered
>     to xAPIC VCPUs and vice-versa.  Make slow path behave like fast path,
>     which never distinguished that.
>     
>     Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
>     Fixes: 682f732ecf73 ("KVM: x86: bump MAX_VCPUS to 288")
>     Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> 
> when run with "./x86/run x86/apic.flat -smp 2 -cpu Nehalem,-x2apic", so I'm removing
> that series from kvm/queue.

Yes, kvm/queue had v2 of the series and I have added the test because
David noticed the broadcast bug while reviewing v3 of that series.
(http://www.spinics.net/lists/kvm/msg142614.html)

The bug was fixed in v4.  I have only posted v4 of this one patch as the
rest seemed ok in v3.