From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [kvm-unit-tests PATCH] x86: apic: add physical broadcast test Date: Thu, 22 Dec 2016 19:23:09 +0100 Message-ID: <20161222182308.GB25692@potion> References: <20161219160429.5237-1-rkrcmar@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: kvm@vger.kernel.org, David Hildenbrand To: Paolo Bonzini Return-path: Received: from mx1.redhat.com ([209.132.183.28]:38152 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S941879AbcLVSXM (ORCPT ); Thu, 22 Dec 2016 13:23:12 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4024D7FD59 for ; Thu, 22 Dec 2016 18:23:12 +0000 (UTC) Content-Disposition: inline In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: 2016-12-22 11:02+0100, Paolo Bonzini: > On 19/12/2016 17:04, Radim Krčmář wrote: >> Broadcast to address 0xff is not exercised by seabios+linux so we better >> test it. >> >> Signed-off-by: Radim Krčmář >> --- >> The bounded wait loop is bad ... time to introduce TSC magic? > > Yeah, the VMX tests already use the TSC (though in the other direction: > they check that _at least_ some time passed). Roughly speaking, 1 > billion TSC units should be plenty, even on a loaded hosts. I will convert it, thanks.