From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Jan Dakinevich <jan.dakinevich@gmail.com>
Cc: kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] KVM: VMX: remove duplicated declaration
Date: Thu, 5 Jan 2017 18:19:10 +0100 [thread overview]
Message-ID: <20170105171909.GC29430@potion> (raw)
In-Reply-To: <1482444833-32183-1-git-send-email-jan.dakinevich@gmail.com>
2016-12-23 01:13+0300, Jan Dakinevich:
> Declaration of VMX_VPID_EXTENT_SUPPORTED_MASK occures twice in the code.
> Probably, it was happened after unsuccessful merge.
Hm, looks even weirder: the deleted hunk was added by bcdde302b826
("KVM: nVMX: invvpid handling improvements") and then 16c2aec6a295
("KVM: nVMX: invvpid handling improvements") duplicated the define and
added the comment on top of it.
> Signed-off-by: Jan Dakinevich <jan.dakinevich@gmail.com>
> ---
Applied to kvm/master, thanks.
> arch/x86/kvm/vmx.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 24db5fb..8c4e9ea 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -132,12 +132,6 @@
>
> #define VMX_MISC_EMULATED_PREEMPTION_TIMER_RATE 5
>
> -#define VMX_VPID_EXTENT_SUPPORTED_MASK \
> - (VMX_VPID_EXTENT_INDIVIDUAL_ADDR_BIT | \
> - VMX_VPID_EXTENT_SINGLE_CONTEXT_BIT | \
> - VMX_VPID_EXTENT_GLOBAL_CONTEXT_BIT | \
> - VMX_VPID_EXTENT_SINGLE_NON_GLOBAL_BIT)
> -
> /*
> * Hyper-V requires all of these, so mark them as supported even though
> * they are just treated the same as all-context.
> --
> 1.9.1
>
prev parent reply other threads:[~2017-01-05 17:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-22 22:13 [PATCH] KVM: VMX: remove duplicated declaration Jan Dakinevich
2017-01-05 17:19 ` Radim Krčmář [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170105171909.GC29430@potion \
--to=rkrcmar@redhat.com \
--cc=jan.dakinevich@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox