From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Cochran Subject: Re: [patch 3/3] PTP: add kvm PTP driver Date: Sat, 14 Jan 2017 16:26:36 +0100 Message-ID: <20170114152636.GA16883@localhost.localdomain> References: <20170113120131.086634482@redhat.com> <20170113120319.777765254@redhat.com> <20170113155657.GD22440@potion> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Marcelo Tosatti , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini , Miroslav Lichvar To: Radim Krcmar Return-path: Received: from mail-wm0-f66.google.com ([74.125.82.66]:35901 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750802AbdANP1Z (ORCPT ); Sat, 14 Jan 2017 10:27:25 -0500 Content-Disposition: inline In-Reply-To: <20170113155657.GD22440@potion> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Jan 13, 2017 at 04:56:58PM +0100, Radim Krcmar wrote: > > +static int __init ptp_kvm_init(void) > > +{ > > + if (!kvm_para_available()) > > + return -ENODEV; > > + > > + kvm_ptp_clock.caps = ptp_kvm_caps; > > + > > + kvm_ptp_clock.ptp_clock = ptp_clock_register(&kvm_ptp_clock.caps, NULL); > > It is a shame that the infrastructure uses polling when the guest could > be notified on every host real time change, but this should be good > enough. This comment makes no sense at all. What do you mean by "host real time change"? Thanks, Richard