From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Cochran Subject: Re: [patch 4/5] PTP: add PTP_SYS_OFFSET emulation via cross timestamps infrastructure Date: Fri, 20 Jan 2017 21:25:02 +0100 Message-ID: <20170120202502.GA10368@localhost.localdomain> References: <20170120122025.665985919@redhat.com> <20170120122503.746158230@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini , Radim Krcmar , Miroslav Lichvar To: Marcelo Tosatti Return-path: Content-Disposition: inline In-Reply-To: <20170120122503.746158230@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Fri, Jan 20, 2017 at 10:20:29AM -0200, Marcelo Tosatti wrote: > Emulate PTP_SYS_OFFSET by using an arithmetic mean of the > realtime samples from ->getcrosststamp callback. This change log is not very informative. Yes, I can see that the new code calculates a mean. But WHY is this needed? And why is this kvm case so special, that it requires its own new flag within the generic PHC subsystem? Thanks, Richard