From mboxrd@z Thu Jan  1 00:00:00 1970
From: Richard Cochran <richardcochran@gmail.com>
Subject: Re: [patch 4/5] PTP: add PTP_SYS_OFFSET emulation via cross
 timestamps infrastructure
Date: Tue, 24 Jan 2017 12:35:17 +0100
Message-ID: <20170124113517.GA2341@localhost.localdomain>
References: <20170120122025.665985919@redhat.com>
 <20170120122503.746158230@redhat.com>
 <20170120202502.GA10368@localhost.localdomain>
 <20170123131913.GA28104@amt.cnet>
 <20170123184415.GA2158@localhost.localdomain>
 <e7ab90e9-6cfd-a926-196b-0018184d6f92@redhat.com>
 <20170124112326.GA30511@amt.cnet>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, Radim Krcmar <rkrcmar@redhat.com>,
        Miroslav Lichvar <mlichvar@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20170124112326.GA30511@amt.cnet>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On Tue, Jan 24, 2017 at 09:23:29AM -0200, Marcelo Tosatti wrote:
> I'm resending v5 with native support for ->gettime and 
> ->getcrosststamps.

And can you please drop the "fake" PTP_SYS_OFFSET stuff?

Here is another reason why this is illogical.  The application can
choose how many samples to take during PTP_SYS_OFFSET.  It will choose
more samples if it wants a better picture of the offsets, but in that
case the "fake" samples would cause more computation in the kernel for
no added benefit.

Thanks,
Richard