From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [kvm:queue 8/8] drivers/ptp/ptp_kvm.c:88:35: error: incompatible type for argument 1 of 'timespec_to_ktime' Date: Mon, 30 Jan 2017 17:53:27 +0100 Message-ID: <20170130165326.GA4859@potion> References: <201701280111.JR9NBsFv%fengguang.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, Paolo Bonzini To: Marcelo Tosatti Return-path: Received: from mx1.redhat.com ([209.132.183.28]:60634 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751878AbdA3Qxf (ORCPT ); Mon, 30 Jan 2017 11:53:35 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D4276C0567B1 for ; Mon, 30 Jan 2017 16:53:30 +0000 (UTC) Content-Disposition: inline In-Reply-To: <201701280111.JR9NBsFv%fengguang.wu@intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Another build failure with the PTP series happens while compiling as a module, ERROR: "pvclock_pvti_cpu0_va" [drivers/ptp/ptp_kvm.ko] undefined! ERROR: "kvm_clock" [drivers/ptp/ptp_kvm.ko] undefined! make[1]: *** [scripts/Makefile.modpost:91: __modpost] Error 1 make: *** [Makefile:1198: modules] Error 2 the following two hunks got rid of that. diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c index 7c4317c00418..995fa260a6da 100644 --- a/arch/x86/kernel/kvmclock.c +++ b/arch/x86/kernel/kvmclock.c @@ -50,6 +50,7 @@ struct pvclock_vsyscall_time_info *pvclock_pvti_cpu0_va(void) { return hv_clock; } +EXPORT_SYMBOL_GPL(pvclock_pvti_cpu0_va); /* * The wallclock is the time of day when we booted. Since then, some time may @@ -182,6 +183,7 @@ struct clocksource kvm_clock = { .mask = CLOCKSOURCE_MASK(64), .flags = CLOCK_SOURCE_IS_CONTINUOUS, }; +EXPORT_SYMBOL_GPL(kvm_clock); int kvm_register_clock(char *txt) {