public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] kvm: vmx: Use the hardware provided GPA instead of page walk
Date: Tue, 7 Feb 2017 21:52:49 +0100	[thread overview]
Message-ID: <20170207205248.GE31091@potion> (raw)
In-Reply-To: <1485542088-18610-1-git-send-email-pbonzini@redhat.com>

2017-01-27 19:34+0100, Paolo Bonzini:
> As in the SVM patch, the guest physical address is passed by
> VMX to x86_emulate_instruction already, so mark the GPA as available
> in vcpu->arch.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---

In line with the SVM patch,

Reviewed-by: Radim Krčmář <rkrcmar@redhat.com>

Still, I don't see why we need a variable that is touched on every VM
exit.  Is this a mere shortcut to propagating the gpa_available bit with
the gpa argument to kvm_mmu_page_fault() and x86_emulate_instruction()?

Thanks.

  parent reply	other threads:[~2017-02-07 20:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-27 18:34 [PATCH] kvm: vmx: Use the hardware provided GPA instead of page walk Paolo Bonzini
2017-02-07 17:21 ` Paolo Bonzini
2017-02-07 20:52 ` Radim Krčmář [this message]
2017-02-08  8:16   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170207205248.GE31091@potion \
    --to=rkrcmar@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox