kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: kvm@vger.kernel.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	rkrcmar@redhat.com, david@redhat.com
Subject: [PATCH RFC 21/21] KVM: x86: simplify pic_ioport_read()
Date: Mon,  6 Mar 2017 14:18:15 +0100	[thread overview]
Message-ID: <20170306131815.12033-22-david@redhat.com> (raw)
In-Reply-To: <20170306131815.12033-1-david@redhat.com>

Signed-off-by: David Hildenbrand <david@redhat.com>
---
 arch/x86/kvm/i8259.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/arch/x86/kvm/i8259.c b/arch/x86/kvm/i8259.c
index 52d21f2..1abd110 100644
--- a/arch/x86/kvm/i8259.c
+++ b/arch/x86/kvm/i8259.c
@@ -417,19 +417,16 @@ static u32 pic_poll_read(struct kvm_kpic_state *s, u32 addr1)
 	return ret;
 }
 
-static u32 pic_ioport_read(void *opaque, u32 addr1)
+static u32 pic_ioport_read(void *opaque, u32 addr)
 {
 	struct kvm_kpic_state *s = opaque;
-	unsigned int addr;
 	int ret;
 
-	addr = addr1;
-	addr &= 1;
 	if (s->poll) {
-		ret = pic_poll_read(s, addr1);
+		ret = pic_poll_read(s, addr);
 		s->poll = 0;
 	} else
-		if (addr == 0)
+		if ((addr & 1) == 0)
 			if (s->read_reg_select)
 				ret = s->isr;
 			else
-- 
2.9.3

      parent reply	other threads:[~2017-03-06 13:24 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-06 13:17 [PATCH RFC 00/21] pic/ioapic/irqchip cleanups + minor fixes David Hildenbrand
2017-03-06 13:17 ` [PATCH RFC 01/21] KVM: x86: race between KVM_SET_GSI_ROUTING and KVM_CREATE_IRQCHIP David Hildenbrand
2017-03-06 13:17 ` [PATCH RFC 02/21] KVM: x86: check against irqchip_mode in kvm_set_routing_entry() David Hildenbrand
2017-03-06 18:08   ` Paolo Bonzini
2017-03-07  9:55     ` David Hildenbrand
2017-03-07 10:53       ` Paolo Bonzini
2017-03-07 14:40         ` Radim Krčmář
2017-03-07 15:32           ` David Hildenbrand
2017-03-06 13:17 ` [PATCH RFC 03/21] KVM: x86: check against irqchip_mode in pic_in_kernel() David Hildenbrand
2017-03-06 13:17 ` [PATCH RFC 04/21] KVM: x86: check against irqchip_mode in ioapic_in_kernel() David Hildenbrand
2017-03-06 13:17 ` [PATCH RFC 05/21] KVM: x86: get rid of pic_irqchip() David Hildenbrand
2017-03-06 13:18 ` [PATCH RFC 06/21] KVM: x86: get rid of ioapic_irqchip() David Hildenbrand
2017-03-06 13:18 ` [PATCH RFC 07/21] KVM: x86: use ioapic_in_kernel() to check for ioapic existence David Hildenbrand
2017-03-06 13:18 ` [PATCH RFC 08/21] KVM: x86: remove duplicate checks for ioapic David Hildenbrand
2017-03-06 13:18 ` [PATCH RFC 09/21] KVM: x86: convert kvm_(set|get)_ioapic() into void David Hildenbrand
2017-03-06 13:18 ` [PATCH RFC 10/21] KVM: x86: don't take kvm->irq_lock when creating IRQCHIP David Hildenbrand
2017-03-06 13:18 ` [PATCH RFC 11/21] KVM: x86: push usage of slots_lock down David Hildenbrand
2017-03-06 13:18 ` [PATCH RFC 12/21] KVM: x86: KVM_IRQCHIP_PIC_MASTER only has 8 pins David Hildenbrand
2017-03-06 13:18 ` [PATCH RFC 13/21] KVM: x86: remove all-vcpu request from kvm_ioapic_init() David Hildenbrand
2017-03-06 13:18 ` [PATCH RFC 14/21] KVM: x86: directly call kvm_make_scan_ioapic_request() in ioapic.c David Hildenbrand
2017-03-06 13:18 ` [PATCH RFC 15/21] KVM: x86: rename kvm_vcpu_request_scan_ioapic() David Hildenbrand
2017-03-06 13:18 ` [PATCH RFC 16/21] KVM: x86: drop goto label in kvm_set_routing_entry() David Hildenbrand
2017-03-06 13:18 ` [PATCH RFC 17/21] KVM: x86: simplify pic_unlock() David Hildenbrand
2017-03-06 13:18 ` [PATCH RFC 18/21] KVM: x86: make kvm_pic_reset() static David Hildenbrand
2017-03-06 13:18 ` [PATCH RFC 19/21] KVM: x86: drop picdev_in_range() David Hildenbrand
2017-03-06 13:18 ` [PATCH RFC 20/21] KVM: x86: set data directly in picdev_read() David Hildenbrand
2017-03-06 13:18 ` David Hildenbrand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170306131815.12033-22-david@redhat.com \
    --to=david@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).