Re: [PATCH v1 02/22] KVM: x86: check against irqchip_mode in kvm_set_routing_entry()

David Hildenbrand
2017-03-15T09:35:40Z

Am 15.03.2017 um 07:33 schrieb Peter Xu:
> On Tue, Mar 14, 2017 at 02:34:30PM +0100, David Hildenbrand wrote:
>> Let's replace the checks for pic_in_kernel() and ioapic_in_kernel() by
>> checks against irqchip_mode. Add another state, indicating that the
>> caller is currently initializing the irqchip.
>>
>> This is necessary to switch pic_in_kernel() and ioapic_in_kernel() to
>> irqchip_mode, too.
>>
>> Also make sure that creation of any route is only possible if we have
>> a lapic in kernel (irqchip_in_kernel()) or if we are currently
>> inititalizing the irqchip.
>
> The subject of the patch is:
>
> KVM: x86: check against irqchip_mode in kvm_set_routing_entry()
>
> IMHO the most significant change this patch brought is the new irqchip
> mode, but we just didn't mention it in the subject...
>
> If we really want this new mode, maybe split current patch into two?
> One for the new mode, one for the change in kvm_set_routing_entry()?
>

I split that up, thanks!

--

Thanks,

David