From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Xu Subject: Re: [PATCH v1 16/22] KVM: x86: drop goto label in kvm_set_routing_entry() Date: Wed, 15 Mar 2017 16:23:29 +0800 Message-ID: <20170315082329.GA5971@pxdev.xzpeter.org> References: <20170314133450.13259-1-david@redhat.com> <20170314133450.13259-17-david@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: kvm@vger.kernel.org, Paolo Bonzini , rkrcmar@redhat.com To: David Hildenbrand Return-path: Received: from mx1.redhat.com ([209.132.183.28]:60850 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751113AbdCOIXd (ORCPT ); Wed, 15 Mar 2017 04:23:33 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5CA68C04B945 for ; Wed, 15 Mar 2017 08:23:33 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170314133450.13259-17-david@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Mar 14, 2017 at 02:34:44PM +0100, David Hildenbrand wrote: > No need for the goto label + local variable "r". > > Signed-off-by: David Hildenbrand Reviewed-by: Peter Xu (Maybe setup_routing_entry() can be cleaned up as well?) -- peterx