From: Peter Xu <peterx@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: kvm@vger.kernel.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>
Subject: Re: [PATCH v2 0/3] KVM: x86: use pic/ioapic destructor when proper
Date: Wed, 15 Mar 2017 16:59:36 +0800 [thread overview]
Message-ID: <20170315085936.GD5971@pxdev.xzpeter.org> (raw)
In-Reply-To: <c22893e8-9dd7-22d1-843b-aae6f6d62026@redhat.com>
On Wed, Mar 15, 2017 at 09:47:14AM +0100, David Hildenbrand wrote:
> Am 15.03.2017 um 09:01 schrieb Peter Xu:
> > v2:
> > - add one more patch (patch 2 in v2) to check pic/ioapic's
> > existance before destroying them
>
> Patch 2+3 without 1 should work, too, right?
We may need that? When destroy VM, it's:
kvm_destroy_vm()
foreach (bus) do kvm_io_bus_destroy()
kfree(bus) <--- [1]
kvm_arch_destroy_vm()
kvm_pic_destroy()
kvm_io_bus_unregister_dev() <--- [2]
Here if without patch 1 we'll reference bus->dev_count in [2], while
actually the bus has been freed already in [1]. Thanks,
-- peterx
next prev parent reply other threads:[~2017-03-15 8:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-15 8:01 [PATCH v2 0/3] KVM: x86: use pic/ioapic destructor when proper Peter Xu
2017-03-15 8:01 ` [PATCH v2 1/3] KVM: x86: clear bus pointer when destroyed Peter Xu
2017-03-21 9:24 ` David Hildenbrand
2017-03-15 8:01 ` [PATCH v2 2/3] KVM: x86: check existance before destroy Peter Xu
2017-03-21 9:24 ` David Hildenbrand
2017-03-15 8:01 ` [PATCH v2 3/3] KVM: x86: use pic/ioapic destructor when destroy vm Peter Xu
2017-03-21 9:25 ` David Hildenbrand
2017-03-15 8:47 ` [PATCH v2 0/3] KVM: x86: use pic/ioapic destructor when proper David Hildenbrand
2017-03-15 8:59 ` Peter Xu [this message]
2017-03-15 9:04 ` David Hildenbrand
2017-03-15 11:15 ` David Hildenbrand
2017-03-16 6:04 ` Peter Xu
2017-03-16 19:32 ` Radim Krčmář
2017-03-17 6:05 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170315085936.GD5971@pxdev.xzpeter.org \
--to=peterx@redhat.com \
--cc=david@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox