From mboxrd@z Thu Jan  1 00:00:00 1970
From: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
Subject: Re: [PATCH v2 00/17] tools/kvm_stat: Misc Patches
Date: Wed, 15 Mar 2017 22:36:36 +0100
Message-ID: <20170315213635.GG14081@potion>
References: <20170310124016.96319-1-raspl@linux.vnet.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org, pbonzini@redhat.com,
        frankja@linux.vnet.ibm.com
To: Stefan Raspl <raspl@linux.vnet.ibm.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:57792 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751848AbdCOVgk (ORCPT <rfc822;kvm@vger.kernel.org>);
        Wed, 15 Mar 2017 17:36:40 -0400
Content-Disposition: inline
In-Reply-To: <20170310124016.96319-1-raspl@linux.vnet.ibm.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

2017-03-10 13:39+0100, Stefan Raspl:
> Assortment of various fixes and improvements for the kvm_stat utility.
> Patches 1-5 are bugfixes.
> Patch 6 provides full PEP8 compliance by inserting the required empty
> lines. It is included as an extra for easy disposal, since that kind of
> patch might be a bit controversial.
> There are some subtle aspects regarding patch 7, as its effects might
> differ per platform. However, I didn't notice any negative effects, only
> improvements.
> Patch 8 is a simple doc update.
> Patches 9-13 provide usability improvements.
> Patches 14-17 add new features.
> 
> Changes in v2:
> - 04/17: Removed chunk that eliminated the only once used libc variable,
>          and changed '3.' -> '3.0'
> - 07/17: Changed '3.' -> '3.0'
> - 16/17: Fixed accidental removal of description for interactive command 'x'

Very nice!

Applied, thanks.

(I will point out few other minor things, but they are not worth
 attention unless you have absolutely nothing to do. :])

> Stefan Raspl (17):
>   tools/kvm_stat: hide cursor
>   tools/kvm_stat: catch curses exceptions only
>   tools/kvm_stat: handle SIGINT in log and batch modes
>   tools/kvm_stat: fix misc glitches
>   tools/kvm_stat: fix trace setup glitch on field updates in
>     TracepointProvider
>   tools/kvm_stat: full PEP8 compliance
>   tools/kvm_stat: reduce perceived idle time on filter updates
>   tools/kvm_stat: document list of interactive commands
>   tools/kvm_stat: display guest name when using pid filter
>   tools/kvm_stat: remove pid filter on empty input
>   tools/kvm_stat: print error messages on faulty pid filter input
>   tools/kvm_stat: display regex when set to non-default
>   tools/kvm_stat: remove regex filter on empty input
>   tools/kvm_stat: add option '--guest'
>   tools/kvm_stat: add interactive command 'c'
>   tools/kvm_stat: add interactive command 'r'
>   tools/kvm_stat: add '%Total' column
> 
>  tools/kvm/kvm_stat/kvm_stat     | 381 +++++++++++++++++++++++++++++++++-------
>  tools/kvm/kvm_stat/kvm_stat.txt |  26 +++
>  2 files changed, 343 insertions(+), 64 deletions(-)
> 
> -- 
> 2.8.4
>