From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Xu Subject: Re: [PATCH v2 0/3] KVM: x86: use pic/ioapic destructor when proper Date: Thu, 16 Mar 2017 14:04:12 +0800 Message-ID: <20170316060412.GK5971@pxdev.xzpeter.org> References: <1489564879-6097-1-git-send-email-peterx@redhat.com> <20170315085936.GD5971@pxdev.xzpeter.org> <2cb28e66-b24a-efba-92d1-55ffd39743c6@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: kvm@vger.kernel.org, Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= To: David Hildenbrand Return-path: Received: from mx1.redhat.com ([209.132.183.28]:56664 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750988AbdCPGET (ORCPT ); Thu, 16 Mar 2017 02:04:19 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C612FC054905 for ; Thu, 16 Mar 2017 06:04:19 +0000 (UTC) Content-Disposition: inline In-Reply-To: <2cb28e66-b24a-efba-92d1-55ffd39743c6@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Mar 15, 2017 at 12:15:24PM +0100, David Hildenbrand wrote: > Am 15.03.2017 um 09:59 schrieb Peter Xu: > > On Wed, Mar 15, 2017 at 09:47:14AM +0100, David Hildenbrand wrote: > >> Am 15.03.2017 um 09:01 schrieb Peter Xu: > >>> v2: > >>> - add one more patch (patch 2 in v2) to check pic/ioapic's > >>> existance before destroying them > >> > >> Patch 2+3 without 1 should work, too, right? > > > > We may need that? When destroy VM, it's: > > > > kvm_destroy_vm() > > foreach (bus) do kvm_io_bus_destroy() > > kfree(bus) <--- [1] > > kvm_arch_destroy_vm() > > kvm_pic_destroy() > > kvm_io_bus_unregister_dev() <--- [2] > > > > Wouldn't the natural way be > > 1. kvm_arch_destroy_vm() > 2. foreach (bus) do kvm_io_bus_destroy() > kfree(bus) > > Then we wouldn't have to deal with suddenly removed buses. But maybe > that order is of importance here ... I'll leave this question for Paolo/Radim, or anyone knows this better than me. :-) -- peterx