From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [PATCH 2/2] kvm: make KVM_COALESCED_MMIO_PAGE_OFFSET public Date: Fri, 31 Mar 2017 15:39:23 +0200 Message-ID: <20170331133923.GB6019@potion> References: <1490961203-7139-1-git-send-email-pbonzini@redhat.com> <1490961203-7139-3-git-send-email-pbonzini@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, lei.cao@stratus.com To: Paolo Bonzini Return-path: Content-Disposition: inline In-Reply-To: <1490961203-7139-3-git-send-email-pbonzini@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org 2017-03-31 13:53+0200, Paolo Bonzini: > Its value has never changed; we might as well make it part of the ABI instead > of using the return value of KVM_CHECK_EXTENSION(KVM_CAP_COALESCED_MMIO). > > Because PPC does not always make MMIO available, the code has to be made > dependent on CONFIG_KVM_MMIO rather than KVM_COALESCED_MMIO_PAGE_OFFSET. > > Signed-off-by: Paolo Bonzini > --- I like the change to CONFIG_KVM_MMIO and the interface isn't suited for dynamic offsets based on enabled features anyway ... Reviewed-by: Radim Krčmář