From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [PATCH 1/2] kvm: make KVM_CAP_COALESCED_MMIO architecture agnostic Date: Fri, 31 Mar 2017 15:41:07 +0200 Message-ID: <20170331134106.GC6019@potion> References: <1490961203-7139-1-git-send-email-pbonzini@redhat.com> <1490961203-7139-2-git-send-email-pbonzini@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, lei.cao@stratus.com To: Paolo Bonzini Return-path: Content-Disposition: inline In-Reply-To: <1490961203-7139-2-git-send-email-pbonzini@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org 2017-03-31 13:53+0200, Paolo Bonzini: > Remove code from architecture files that can be moved to virt/kvm, since there > is already common code for coalesced MMIO. > > Signed-off-by: Paolo Bonzini > --- > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > @@ -2919,6 +2919,11 @@ static long kvm_vm_ioctl_check_extension_generic(struct kvm *kvm, long arg) > +#ifdef KVM_COALESCED_MMIO_PAGE_OFFSET > + case KVM_CAP_COALESCED_MMIO: > + return KVM_COALESCED_MMIO_PAGE_OFFSET; > + break; This 'break;' is pointless and would be best removed when applying, thanks. > +#endif