From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [PATCH] KVM: nVMX: do not leak PML full vmexit to L1 Date: Fri, 31 Mar 2017 15:47:13 +0200 Message-ID: <20170331134713.GA7774@potion> References: <20170331081926.28463-1-lprosek@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: kvm@vger.kernel.org, kai.huang@linux.intel.com, wanpeng.li@hotmail.com To: Ladi Prosek Return-path: Received: from mx1.redhat.com ([209.132.183.28]:55654 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932942AbdCaNrS (ORCPT ); Fri, 31 Mar 2017 09:47:18 -0400 Content-Disposition: inline In-Reply-To: <20170331081926.28463-1-lprosek@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: 2017-03-31 10:19+0200, Ladi Prosek: > The PML feature is not exposed to guests so we should not be forwarding > the vmexit either. > > This commit fixes BSOD 0x20001 (HYPERVISOR_ERROR) when running Hyper-V > enabled Windows Server 2016 in L1 on hardware that supports PML. > > Fixes: 843e4330573c ("KVM: VMX: Add PML support in VMX") > Signed-off-by: Ladi Prosek > --- Good catch, Reviewed-by: Radim Krčmář > arch/x86/kvm/vmx.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c > index 2ee00db..6051832 100644 > --- a/arch/x86/kvm/vmx.c > +++ b/arch/x86/kvm/vmx.c > @@ -8198,6 +8198,9 @@ static bool nested_vmx_exit_handled(struct kvm_vcpu *vcpu) > return nested_cpu_has2(vmcs12, SECONDARY_EXEC_XSAVES); > case EXIT_REASON_PREEMPTION_TIMER: > return false; > + case EXIT_REASON_PML_FULL: > + /* We don't expose PML support to L1. */ > + return false; > default: > return true; > } > -- > 2.9.3 >