From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v6] vfio error recovery: kernel support
Date: Thu, 6 Apr 2017 00:56:14 +0300
Message-ID: <20170406005028-mutt-send-email-mst@kernel.org>
References: <1490260051-6046-1-git-send-email-caoj.fnst@cn.fujitsu.com>
 <20170324161238.366ce6a7@t450s.home>
 <58DA6954.2000601@cn.fujitsu.com>
 <20170328101233.74f50a92@t450s.home>
 <20170329000148.GA18849@redhat.com>
 <20170328205513.21b97381@t450s.home>
 <20170330205823-mutt-send-email-mst@kernel.org>
 <20170330121652.2ac8fa62@t450s.home>
 <58E4B0C9.50109@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Alex Williamson <alex.williamson@redhat.com>,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        qemu-devel@nongnu.org, izumi.taku@jp.fujitsu.com
To: Cao jin <caoj.fnst@cn.fujitsu.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:35988 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751881AbdDEV4T (ORCPT <rfc822;kvm@vger.kernel.org>);
        Wed, 5 Apr 2017 17:56:19 -0400
Content-Disposition: inline
In-Reply-To: <58E4B0C9.50109@cn.fujitsu.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Wed, Apr 05, 2017 at 04:54:33PM +0800, Cao jin wrote:
> Apparently, I don't have experience to induce non-fatal error, device
> error is more of a chance related with the environment(temperature,
> humidity, etc) as I understand.

I'm not sure how to interpret this statement. I think what Alex is
saying is simply that patches should include some justification. They
make changes but what are they improving?
For example:

	I tested device ABC in conditions DEF. Without a patch VM
	stops. With the patches applied VM recovers and proceeds to
	use the device normally.

is one reasonable justification imho.

-- 
MST