kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Leo Yan <leo.yan@linaro.org>
To: Auger Eric <eric.auger@redhat.com>
Cc: Russell King <linux@armlinux.org.uk>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Baptiste Reynal <b.reynal@virtualopensystems.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	rtc-linux@googlegroups.com, linux-arm-kernel@lists.infradead.org,
	kvm@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH 4/5] vfio: platform: Convert to use devm_*()
Date: Thu, 6 Apr 2017 22:17:31 +0800	[thread overview]
Message-ID: <20170406141731.GA27245@leoy-linaro> (raw)
In-Reply-To: <10625a88-3d6d-de52-8299-3ba0031317f8@redhat.com>

On Sun, Apr 02, 2017 at 04:45:28PM +0200, Auger Eric wrote:
> Hi Leo,
> 
> On 26/03/2017 16:41, Leo Yan wrote:
> > Convert driver to use devm_*() APIs so rely on driver model core layer
> > to manage resources. This eliminates error path boilerplate and makes
> > code neat.
> > 
> > This patch also renames amba_id structure, the old code used some code
> > which directly copied from other driver.
> > 
> > Signed-off-by: Leo Yan <leo.yan@linaro.org>
> Looks good to me
> Reviewed-by: Eric Auger <eric.auger@redhat.com>

Thanks for reviewing, Eric.

> May be interesting to go further converting as well the vfio-platform
> driver but this can be done later on.

Looked a bit for vfio-platform driver and I'm not sure if need some
converting within function vfio_platform_probe_common(). So I'd like
to leave this to who really understand the subsystem :)

[...]

Thanks,
Leo Yan

  reply	other threads:[~2017-04-06 14:17 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-26 14:41 [PATCH 0/5] Convert to use devm_*() for amba attached modules Leo Yan
     [not found] ` <1490539314-9681-1-git-send-email-leo.yan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-03-26 14:41   ` [PATCH 1/5] Input: ambakmi - Convert to use devm_*() Leo Yan
     [not found]     ` <1490539314-9681-2-git-send-email-leo.yan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-03-26 14:50       ` Russell King - ARM Linux
     [not found]         ` <20170326145023.GO7909-l+eeeJia6m9URfEZ8mYm6t73F7V6hmMc@public.gmane.org>
2017-03-26 15:23           ` Leo Yan
2017-03-26 14:41   ` [PATCH 2/5] drivers/rtc/rtc-pl030.c: " Leo Yan
2017-03-29  1:45     ` Linus Walleij
2017-03-26 14:41   ` [PATCH 3/5] drivers/rtc/rtc-pl031.c: " Leo Yan
     [not found]     ` <1490539314-9681-4-git-send-email-leo.yan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-03-29  1:46       ` Linus Walleij
2017-03-26 14:41   ` [PATCH 4/5] vfio: platform: " Leo Yan
     [not found]     ` <1490539314-9681-5-git-send-email-leo.yan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-04-02 14:45       ` Auger Eric
2017-04-06 14:17         ` Leo Yan [this message]
2017-03-26 14:41   ` [PATCH 5/5] ALSA: AACI: Convert to use devm_ioremap_resource() Leo Yan
     [not found]     ` <1490539314-9681-6-git-send-email-leo.yan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-03-26 14:54       ` Russell King - ARM Linux
2017-03-26 15:20   ` [PATCH 0/5] Convert to use devm_*() for amba attached modules Alexandre Belloni
     [not found]     ` <20170326152050.v47z36eud6xvrcpt-m++hUPXGwpdeoWH0uzbU5w@public.gmane.org>
2017-03-26 15:38       ` Leo Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170406141731.GA27245@leoy-linaro \
    --to=leo.yan@linaro.org \
    --cc=a.zummo@towertech.it \
    --cc=alex.williamson@redhat.com \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=b.reynal@virtualopensystems.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=eric.auger@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=perex@perex.cz \
    --cc=rtc-linux@googlegroups.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).