kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Radim Krčmář" <rkrcmar@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: Steve Rutherford <srutherford@google.com>,
	KVM list <kvm@vger.kernel.org>,
	Paolo Bonzini <pbonzini@redhat.com>, Peter Xu <peterx@redhat.com>
Subject: Re: [PATCH v3 01/24] KVM: x86: race between KVM_SET_GSI_ROUTING and KVM_CREATE_IRQCHIP
Date: Tue, 25 Apr 2017 16:58:10 +0200	[thread overview]
Message-ID: <20170425145809.GG5713@potion> (raw)
In-Reply-To: <7e88e9b1-de11-0715-7849-3c12f644e40b@redhat.com>

2017-04-25 14:34+0200, David Hildenbrand:
> On 25.04.2017 00:39, Steve Rutherford wrote:
>> Sorry to resurrect this thread. There's an srcu_synchronize_expedited
>> call in kvm_set_irq_routing, so this lock might get held for a fairly
>> long while. Wouldn't it be a better idea to check the irqchip mode?
>> 
> 
> We could maybe check for kvm->arch.irqchip_mode == KVM_IRQCHIP_NONE
> here under lock instead of in the function itself. Maybe we then even
> don't need patch NR 2. Will have a look!

Sounds good and the extra mode would be obsolete.  Checking in
kvm_main.c will just need a new arch hook.  The patches are already in
kvm/next, though, so please prepare it as a fix.

Thanks.

  reply	other threads:[~2017-04-25 14:58 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-07  8:50 [PATCH v3 00/24] pic/ioapic/irqchip cleanups + minor fixes David Hildenbrand
2017-04-07  8:50 ` [PATCH v3 01/24] KVM: x86: race between KVM_SET_GSI_ROUTING and KVM_CREATE_IRQCHIP David Hildenbrand
2017-04-24 22:39   ` Steve Rutherford
2017-04-25 12:34     ` David Hildenbrand
2017-04-25 14:58       ` Radim Krčmář [this message]
2017-04-25 19:03     ` [PATCH] KVM: x86: don't hold kvm->lock in KVM_SET_GSI_ROUTING David Hildenbrand
2017-04-25 19:38       ` Steve Rutherford
2017-04-25 19:59       ` Radim Krčmář
2017-04-26  8:40         ` David Hildenbrand
2017-04-26 14:27           ` Radim Krčmář
2017-04-26 15:21             ` David Hildenbrand
2017-04-26 20:47               ` Radim Krčmář
2017-04-26 12:33       ` kbuild test robot
2017-04-26 14:24         ` Radim Krčmář
2017-04-07  8:50 ` [PATCH v3 02/24] KVM: x86: new irqchip mode KVM_IRQCHIP_INIT_IN_PROGRESS David Hildenbrand
2017-04-12 18:26   ` Radim Krčmář
2017-04-12 19:55     ` David Hildenbrand
2017-04-07  8:50 ` [PATCH v3 03/24] KVM: x86: check against irqchip_mode in kvm_set_routing_entry() David Hildenbrand
2017-04-12 18:36   ` Radim Krčmář
2017-04-12 19:56     ` David Hildenbrand
2017-04-07  8:50 ` [PATCH v3 04/24] KVM: x86: check against irqchip_mode in pic_in_kernel() David Hildenbrand
2017-04-07  8:50 ` [PATCH v3 05/24] KVM: x86: check against irqchip_mode in ioapic_in_kernel() David Hildenbrand
2017-04-07  8:50 ` [PATCH v3 06/24] KVM: x86: get rid of pic_irqchip() David Hildenbrand
2017-04-07  8:50 ` [PATCH v3 07/24] KVM: x86: get rid of ioapic_irqchip() David Hildenbrand
2017-04-07  8:50 ` [PATCH v3 08/24] KVM: x86: use ioapic_in_kernel() to check for ioapic existence David Hildenbrand
2017-04-07  8:50 ` [PATCH v3 09/24] KVM: x86: remove duplicate checks for ioapic David Hildenbrand
2017-04-07  8:50 ` [PATCH v3 10/24] KVM: x86: convert kvm_(set|get)_ioapic() into void David Hildenbrand
2017-04-07  8:50 ` [PATCH v3 11/24] KVM: x86: don't take kvm->irq_lock when creating IRQCHIP David Hildenbrand
2017-04-07  8:50 ` [PATCH v3 12/24] KVM: x86: push usage of slots_lock down David Hildenbrand
2017-04-07  8:50 ` [PATCH v3 13/24] KVM: x86: KVM_IRQCHIP_PIC_MASTER only has 8 pins David Hildenbrand
2017-04-07  8:50 ` [PATCH v3 14/24] KVM: x86: remove all-vcpu request from kvm_ioapic_init() David Hildenbrand
2017-04-07  8:50 ` [PATCH v3 15/24] KVM: x86: directly call kvm_make_scan_ioapic_request() in ioapic.c David Hildenbrand
2017-04-07  8:50 ` [PATCH v3 16/24] KVM: x86: rename kvm_vcpu_request_scan_ioapic() David Hildenbrand
2017-04-07  8:50 ` [PATCH v3 17/24] KVM: x86: drop goto label in kvm_set_routing_entry() David Hildenbrand
2017-04-07  8:50 ` [PATCH v3 18/24] KVM: x86: cleanup return handling in setup_routing_entry() David Hildenbrand
2017-04-07  8:50 ` [PATCH v3 19/24] KVM: x86: simplify pic_unlock() David Hildenbrand
2017-04-07  8:50 ` [PATCH v3 20/24] KVM: x86: make kvm_pic_reset() static David Hildenbrand
2017-04-07  8:50 ` [PATCH v3 21/24] KVM: x86: drop picdev_in_range() David Hildenbrand
2017-04-07  8:50 ` [PATCH v3 22/24] KVM: x86: set data directly in picdev_read() David Hildenbrand
2017-04-07  8:50 ` [PATCH v3 23/24] KVM: x86: simplify pic_ioport_read() David Hildenbrand
2017-04-07  8:50 ` [PATCH v3 24/24] KVM: x86: use irqchip_kernel() to check for pic+ioapic David Hildenbrand
2017-04-12 18:58 ` [PATCH v3 00/24] pic/ioapic/irqchip cleanups + minor fixes Radim Krčmář
2017-04-12 19:59   ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170425145809.GG5713@potion \
    --to=rkrcmar@redhat.com \
    --cc=david@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=srutherford@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).