From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [kvm-unit-tests PATCH] lib: Add headers to generic library files Date: Tue, 25 Apr 2017 17:32:28 +0200 Message-ID: <20170425153228.GH5713@potion> References: <1491571017-12452-1-git-send-email-thuth@redhat.com> <20170407134901.3qdx7mstlsohqeud@kamzik.brq.redhat.com> <50161dcd-c619-22cd-5707-745744e52c92@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: pbonzini@redhat.com, kvm@vger.kernel.org To: Thomas Huth Return-path: Received: from mx1.redhat.com ([209.132.183.28]:31017 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1950390AbdDYPcb (ORCPT ); Tue, 25 Apr 2017 11:32:31 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5DB1E3D972 for ; Tue, 25 Apr 2017 15:32:31 +0000 (UTC) Content-Disposition: inline In-Reply-To: <50161dcd-c619-22cd-5707-745744e52c92@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: 2017-04-25 09:11+0200, Thomas Huth: > On 07.04.2017 15:49, Andrew Jones wrote: >> On Fri, Apr 07, 2017 at 03:16:57PM +0200, Thomas Huth wrote: >>> Many files in the lib folder do not have proper statements about >>> their license. Add such a header there so that it is clear under >>> which conditions the code can be used. >>> >>> Signed-off-by: Thomas Huth >>> --- >>> diff --git a/lib/argv.c b/lib/argv.c >>> @@ -1,3 +1,10 @@ >>> +/* >>> + * Set up arguments for main() and prepare environment variables >>> + * >>> + * This code is free software; you can redistribute it and/or modify it >>> + * under the terms of the GNU Library General Public License version 2. >>> + */ >>> + >>> #include "libcflat.h" >>> #include "auxinfo.h" >>> >> >> Reviewed-by: Andrew Jones > > *ping* (Sorry, I'll need to double-check all unit test patches from that time.) > Paolo, Radim, could you pick this up please if it sounds OK for you? It does, the licensing follows COPYRIGHT and I assume that we can't change the license without a lot of legal hassle. Took me a while to realize what isn't clear: libcflat.h is GPL 2 and being explicit with the border between GPL 2 and LGPL 2 sounds good for re-usability of the code. (I assume that the whole kvm-unit-tests is effectively GPL 2, but parts of it are more benevolent.) Applied, thanks.