From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [PATCH] KVM: x86: don't hold kvm->lock in KVM_SET_GSI_ROUTING Date: Wed, 26 Apr 2017 16:27:11 +0200 Message-ID: <20170426142710.GB26029@potion> References: <20170425190306.20392-1-david@redhat.com> <20170425195954.GJ5713@potion> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: srutherford@google.com, kvm@vger.kernel.org, pbonzini@redhat.com To: David Hildenbrand Return-path: Received: from mx1.redhat.com ([209.132.183.28]:56990 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S3001126AbdDZO1Q (ORCPT ); Wed, 26 Apr 2017 10:27:16 -0400 Content-Disposition: inline In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: 2017-04-26 10:40+0200, David Hildenbrand: > On 25.04.2017 21:59, Radim Krčmář wrote: >> 2017-04-25 21:03+0200, David Hildenbrand: >>> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h >>> @@ -504,6 +504,7 @@ void vcpu_put(struct kvm_vcpu *vcpu); >>> #ifdef __KVM_HAVE_IOAPIC >>> void kvm_arch_post_irq_ack_notifier_list_update(struct kvm *kvm); >>> void kvm_arch_post_irq_routing_update(struct kvm *kvm); >>> +bool kvm_arch_can_set_irq_routing(struct kvm *kvm); >> >> (A nitpick: it might be useful even without __KVM_HAVE_IOAPIC so weak >> linking would probably be cleaner for a slow path.) >> >>> #else >>> static inline void kvm_arch_post_irq_ack_notifier_list_update(struct kvm *kvm) >>> { >>> @@ -511,6 +512,10 @@ static inline void kvm_arch_post_irq_ack_notifier_list_update(struct kvm *kvm) >>> static inline void kvm_arch_post_irq_routing_update(struct kvm *kvm) >>> { >>> } >>> +static bool kvm_arch_can_set_irq_routing(struct kvm *kvm) >>> +{ >>> + return true; >>> +} >>> #endif >>> > > Makes sense, shall I resend or can you fix that up when applying? Please send a v2, it's going to be automatically compile-tested on all arches that way. :)