From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Subject: Re: [PATCH v2 1/9] KVM: add kvm_{test,clear}_request to replace {test,clear}_bit Date: Thu, 27 Apr 2017 13:38:38 +0200 Message-ID: <20170427133838.35d1232e.cornelia.huck@de.ibm.com> References: <20170426203227.12321-1-rkrcmar@redhat.com> <20170426203227.12321-2-rkrcmar@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Christoffer Dall , Andrew Jones , Marc Zyngier , Paolo Bonzini , Christian Borntraeger , James Hogan , Paul Mackerras To: Radim =?UTF-8?B?S3LEjW3DocWZ?= Return-path: Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:49576 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753956AbdD0Lis (ORCPT ); Thu, 27 Apr 2017 07:38:48 -0400 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v3RBcknG145865 for ; Thu, 27 Apr 2017 07:38:47 -0400 Received: from e06smtp15.uk.ibm.com (e06smtp15.uk.ibm.com [195.75.94.111]) by mx0a-001b2d01.pphosted.com with ESMTP id 2a34ycs50k-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 27 Apr 2017 07:38:47 -0400 Received: from localhost by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 27 Apr 2017 12:38:43 +0100 In-Reply-To: <20170426203227.12321-2-rkrcmar@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, 26 Apr 2017 22:32:19 +0200 Radim Krčmář wrote: > Users were expected to use kvm_check_request() for testing and clearing, > but request have expanded their use since then and some users want to > only test or do a faster clear. > > Make sure that requests are not directly accessed with bit operations. > > Reviewed-by: Christian Borntraeger > Signed-off-by: Radim Krčmář > --- > arch/mips/kvm/emulate.c | 2 +- > arch/powerpc/kvm/book3s_pr.c | 2 +- > arch/powerpc/kvm/book3s_pr_papr.c | 2 +- > arch/powerpc/kvm/booke.c | 4 ++-- > arch/powerpc/kvm/powerpc.c | 2 +- > arch/s390/kvm/kvm-s390.c | 2 +- > arch/x86/kvm/vmx.c | 2 +- > arch/x86/kvm/x86.c | 8 ++++---- > include/linux/kvm_host.h | 14 ++++++++++++-- > 9 files changed, 24 insertions(+), 14 deletions(-) Reviewed-by: Cornelia Huck