kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Ladi Prosek <lprosek@redhat.com>,
	kvm@vger.kernel.org, kai.huang@linux.intel.com,
	wanpeng.li@hotmail.com
Subject: Re: [PATCH] KVM: nVMX: do not leak PML full vmexit to L1
Date: Tue, 2 May 2017 20:31:42 +0200	[thread overview]
Message-ID: <20170502183141.GA26679@potion> (raw)
In-Reply-To: <6eebde60-b792-8d2e-154c-89a3b3153221@redhat.com>

2017-05-02 15:05+0200, Paolo Bonzini:
> On 31/03/2017 10:19, Ladi Prosek wrote:
>> The PML feature is not exposed to guests so we should not be forwarding
>> the vmexit either.
>> 
>> This commit fixes BSOD 0x20001 (HYPERVISOR_ERROR) when running Hyper-V
>> enabled Windows Server 2016 in L1 on hardware that supports PML.
>> 
>> Fixes: 843e4330573c ("KVM: VMX: Add PML support in VMX")
>> Signed-off-by: Ladi Prosek <lprosek@redhat.com>
>> ---
>>  arch/x86/kvm/vmx.c | 3 +++
>>  1 file changed, 3 insertions(+)
>> 
>> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
>> index 2ee00db..6051832 100644
>> --- a/arch/x86/kvm/vmx.c
>> +++ b/arch/x86/kvm/vmx.c
>> @@ -8198,6 +8198,9 @@ static bool nested_vmx_exit_handled(struct kvm_vcpu *vcpu)
>>  		return nested_cpu_has2(vmcs12, SECONDARY_EXEC_XSAVES);
>>  	case EXIT_REASON_PREEMPTION_TIMER:
>>  		return false;
>> +	case EXIT_REASON_PML_FULL:
>> +		/* We don't expose PML support to L1. */
>> +		return false;
>>  	default:
>>  		return true;
>>  	}
>> 
> 
> This fell through the cracks, I'm queueing it now.

It is in Linus' tree as ab007cc94ff9, we are just missing it in queue
and next as they haven't merged yet.

      reply	other threads:[~2017-05-02 18:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-31  8:19 [PATCH] KVM: nVMX: do not leak PML full vmexit to L1 Ladi Prosek
2017-03-31 13:47 ` Radim Krčmář
2017-04-03 11:24 ` David Hildenbrand
2017-04-03 11:27 ` David Hildenbrand
2017-04-03 11:43   ` Paolo Bonzini
2017-04-03 11:55     ` David Hildenbrand
2017-04-05 14:50 ` Radim Krčmář
2017-05-02 13:05 ` Paolo Bonzini
2017-05-02 18:31   ` Radim Krčmář [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170502183141.GA26679@potion \
    --to=rkrcmar@redhat.com \
    --cc=kai.huang@linux.intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=lprosek@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=wanpeng.li@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).