From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [PATCH] KVM: nVMX: do not leak PML full vmexit to L1 Date: Tue, 2 May 2017 20:31:42 +0200 Message-ID: <20170502183141.GA26679@potion> References: <20170331081926.28463-1-lprosek@redhat.com> <6eebde60-b792-8d2e-154c-89a3b3153221@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Ladi Prosek , kvm@vger.kernel.org, kai.huang@linux.intel.com, wanpeng.li@hotmail.com To: Paolo Bonzini Return-path: Received: from mx1.redhat.com ([209.132.183.28]:34548 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750896AbdEBSbp (ORCPT ); Tue, 2 May 2017 14:31:45 -0400 Content-Disposition: inline In-Reply-To: <6eebde60-b792-8d2e-154c-89a3b3153221@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: 2017-05-02 15:05+0200, Paolo Bonzini: > On 31/03/2017 10:19, Ladi Prosek wrote: >> The PML feature is not exposed to guests so we should not be forwarding >> the vmexit either. >> >> This commit fixes BSOD 0x20001 (HYPERVISOR_ERROR) when running Hyper-V >> enabled Windows Server 2016 in L1 on hardware that supports PML. >> >> Fixes: 843e4330573c ("KVM: VMX: Add PML support in VMX") >> Signed-off-by: Ladi Prosek >> --- >> arch/x86/kvm/vmx.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c >> index 2ee00db..6051832 100644 >> --- a/arch/x86/kvm/vmx.c >> +++ b/arch/x86/kvm/vmx.c >> @@ -8198,6 +8198,9 @@ static bool nested_vmx_exit_handled(struct kvm_vcpu *vcpu) >> return nested_cpu_has2(vmcs12, SECONDARY_EXEC_XSAVES); >> case EXIT_REASON_PREEMPTION_TIMER: >> return false; >> + case EXIT_REASON_PML_FULL: >> + /* We don't expose PML support to L1. */ >> + return false; >> default: >> return true; >> } >> > > This fell through the cracks, I'm queueing it now. It is in Linus' tree as ab007cc94ff9, we are just missing it in queue and next as they haven't merged yet.