From: "Radim Krčmář" <rkrcmar@redhat.com>
To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: Christoffer Dall <cdall@linaro.org>,
Andrew Jones <drjones@redhat.com>,
Marc Zyngier <marc.zyngier@arm.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Cornelia Huck <cornelia.huck@de.ibm.com>,
James Hogan <james.hogan@imgtec.com>,
Paul Mackerras <paulus@ozlabs.org>
Subject: Re: [PATCH v2 3/9] KVM: remove #ifndef CONFIG_S390 around kvm_vcpu_wake_up
Date: Wed, 3 May 2017 18:05:33 +0200 [thread overview]
Message-ID: <20170503160532.GB26679@potion> (raw)
In-Reply-To: <20170426203227.12321-4-rkrcmar@redhat.com>
2017-04-26 22:32+0200, Radim Krčmář:
> The #ifndef was protecting a missing halt_wakeup stat, but that is no
> longer necessary.
It was also protecting smp_send_reschedule() in kvm_vcpu_kick() and I
didn't include Christian's patch that exported it and also missed the
warning. Going to send v3 of this patch that removes the ifdef really
only around kvm_vcpu_wake_up().
Sorry for that.
> Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
> Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
> ---
> virt/kvm/kvm_main.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 357e67cba32e..e5d52b46b531 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -2195,7 +2195,6 @@ void kvm_vcpu_block(struct kvm_vcpu *vcpu)
> }
> EXPORT_SYMBOL_GPL(kvm_vcpu_block);
>
> -#ifndef CONFIG_S390
> void kvm_vcpu_wake_up(struct kvm_vcpu *vcpu)
> {
> struct swait_queue_head *wqp;
> @@ -2225,7 +2224,6 @@ void kvm_vcpu_kick(struct kvm_vcpu *vcpu)
> put_cpu();
> }
> EXPORT_SYMBOL_GPL(kvm_vcpu_kick);
> -#endif /* !CONFIG_S390 */
>
> int kvm_vcpu_yield_to(struct kvm_vcpu *target)
> {
> --
> 2.12.2
>
next prev parent reply other threads:[~2017-05-03 16:05 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 20:32 [PATCH v2 0/9] KVM: towards maintainable kvm_make_all_cpus_request() Radim Krčmář
2017-04-26 20:32 ` [PATCH v2 1/9] KVM: add kvm_{test,clear}_request to replace {test,clear}_bit Radim Krčmář
2017-04-27 11:33 ` Andrew Jones
2017-04-27 11:38 ` Cornelia Huck
2017-04-26 20:32 ` [PATCH v2 2/9] KVM: x86: always use kvm_make_request instead of set_bit Radim Krčmář
2017-04-27 11:33 ` Andrew Jones
2017-04-26 20:32 ` [PATCH v2 3/9] KVM: remove #ifndef CONFIG_S390 around kvm_vcpu_wake_up Radim Krčmář
2017-04-27 11:45 ` Cornelia Huck
2017-05-03 16:05 ` Radim Krčmář [this message]
2017-05-03 16:16 ` [PATCH v3] " Radim Krčmář
2017-05-03 17:04 ` Cornelia Huck
2017-04-26 20:32 ` [PATCH v2 4/9] KVM: mark requests that do not need a wakeup Radim Krčmář
2017-04-27 11:35 ` Andrew Jones
2017-04-27 12:00 ` Cornelia Huck
2017-04-26 20:32 ` [PATCH v2 5/9] KVM: perform a wake_up in kvm_make_all_cpus_request Radim Krčmář
2017-04-27 11:36 ` Andrew Jones
2017-04-27 12:06 ` Cornelia Huck
2017-04-27 12:15 ` Paolo Bonzini
2017-04-26 20:32 ` [PATCH v2 6/9] KVM: add explicit barrier to kvm_vcpu_kick Radim Krčmář
2017-04-26 20:32 ` [PATCH v2 7/9] KVM: improve arch vcpu request defining Radim Krčmář
2017-04-27 12:11 ` Cornelia Huck
2017-04-26 20:32 ` [PATCH v2 8/9] KVM: return if kvm_vcpu_wake_up() did wake up the VCPU Radim Krčmář
2017-04-27 11:41 ` Andrew Jones
2017-04-26 20:32 ` [PATCH v2 9/9] KVM: mark requests that need synchronization Radim Krčmář
2017-04-27 11:55 ` Andrew Jones
2017-04-27 12:36 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170503160532.GB26679@potion \
--to=rkrcmar@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cdall@linaro.org \
--cc=cornelia.huck@de.ibm.com \
--cc=drjones@redhat.com \
--cc=james.hogan@imgtec.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=paulus@ozlabs.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox