* [kvm-unit-tests PATCH v1] lib: fix compilation warning
@ 2017-05-12 10:47 David Hildenbrand
2017-05-12 12:22 ` Thomas Huth
2017-05-12 15:11 ` Radim Krčmář
0 siblings, 2 replies; 3+ messages in thread
From: David Hildenbrand @ 2017-05-12 10:47 UTC (permalink / raw)
To: kvm
Cc: Paolo Bonzini, Radim Krčmář, Thomas Huth, david,
David Matlack
GCC doesn't like comparison of signed and unsigned values.
Signed-off-by: David Hildenbrand <david@redhat.com>
---
lib/report.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/report.c b/lib/report.c
index aa23b65..f7af596 100644
--- a/lib/report.c
+++ b/lib/report.c
@@ -29,7 +29,7 @@ void report_pass(void)
void report_prefix_pushf(const char *prefix_fmt, ...)
{
va_list va;
- int len;
+ unsigned int len;
int start;
spin_lock(&lock);
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [kvm-unit-tests PATCH v1] lib: fix compilation warning
2017-05-12 10:47 [kvm-unit-tests PATCH v1] lib: fix compilation warning David Hildenbrand
@ 2017-05-12 12:22 ` Thomas Huth
2017-05-12 15:11 ` Radim Krčmář
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2017-05-12 12:22 UTC (permalink / raw)
To: David Hildenbrand, kvm
Cc: Paolo Bonzini, Radim Krčmář, David Matlack
On 12.05.2017 12:47, David Hildenbrand wrote:
> GCC doesn't like comparison of signed and unsigned values.
>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
> lib/report.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/report.c b/lib/report.c
> index aa23b65..f7af596 100644
> --- a/lib/report.c
> +++ b/lib/report.c
> @@ -29,7 +29,7 @@ void report_pass(void)
> void report_prefix_pushf(const char *prefix_fmt, ...)
> {
> va_list va;
> - int len;
> + unsigned int len;
> int start;
>
> spin_lock(&lock);
This fixes the problem for me, too:
Tested-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [kvm-unit-tests PATCH v1] lib: fix compilation warning
2017-05-12 10:47 [kvm-unit-tests PATCH v1] lib: fix compilation warning David Hildenbrand
2017-05-12 12:22 ` Thomas Huth
@ 2017-05-12 15:11 ` Radim Krčmář
1 sibling, 0 replies; 3+ messages in thread
From: Radim Krčmář @ 2017-05-12 15:11 UTC (permalink / raw)
To: David Hildenbrand; +Cc: kvm, Paolo Bonzini, Thomas Huth, David Matlack
2017-05-12 12:47+0200, David Hildenbrand:
> GCC doesn't like comparison of signed and unsigned values.
>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-12 15:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-12 10:47 [kvm-unit-tests PATCH v1] lib: fix compilation warning David Hildenbrand
2017-05-12 12:22 ` Thomas Huth
2017-05-12 15:11 ` Radim Krčmář
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox