Re: [kvm-unit-tests PATCH v1 2/6] s390x: basic self test

David Hildenbrand
2017-05-17T16:50:50Z

>>>> + if (strcmp(argv[1], "test") != 0)
>>>> + report_abort("wrong parameter value");
>>>> + if (strcmp(argv[2], "123") != 0)
>>>> + report_abort("wrong parameter value");
>>>> +
>>>> + report("test true", true, 0);
>>> ^
>>> It seems you'll be doing v2 -- please remove this zero in it.
>>
>> Thanks, if that would throw an error during compile time like printf, it
>> would be perfect.
>>
>> Yes, I'll resend!
>
> Thinking more about it, the test would look better if we used report()
> instead of if()+report_abort() and a final report, something like:
>
> report("argv[0] == PROGNAME", !strcmp(argv[0], "s390x/selftest.elf"));
> report("argv[1] == test", !strcmp(argv[1], "test"));
> report("argv[2] == 123", !strcmp(argv[2], "123"));
>
> This is also a nitpick and I'll gladly accept the original version. :)
>

Thanks - I'll add that change and send a new version out tomorrow.

--

Thanks,

David