From mboxrd@z Thu Jan  1 00:00:00 1970
From: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
Subject: Re: [kvm-unit-tests PATCH] lib: use %zu conversion for sizeof to fix
 i386 build
Date: Fri, 12 May 2017 17:28:47 +0200
Message-ID: <20170512152846.GC13216@potion>
References: <20170512151545.13507-1-rkrcmar@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: Paolo Bonzini <pbonzini@redhat.com>,
        Peter Feiner <pfeiner@google.com>
To: kvm@vger.kernel.org
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:49054 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1755666AbdELP2u (ORCPT <rfc822;kvm@vger.kernel.org>);
        Fri, 12 May 2017 11:28:50 -0400
Content-Disposition: inline
In-Reply-To: <20170512151545.13507-1-rkrcmar@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

2017-05-12 17:15+0200, Radim Krčmář:
> Fixes this GCC error:
> 
> In file included from lib/report.c:13:0:
> lib/libcflat.h:134:10: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 6 has type ‘unsigned int’ [-Werror=format=]
>    printf("%s:%d: assert failed: %s: " fmt "\n",  \
>           ^
> lib/report.c:53:2: note: in expansion of macro ‘assert_msg’
>   assert_msg(len < sizeof(prefixes), "%d >= %lu", len, sizeof(prefixes));
>   ^~~~~~~~~~
> lib/report.c:53:46: note: format string is defined here
>   assert_msg(len < sizeof(prefixes), "%d >= %lu", len, sizeof(prefixes));
>                                             ~~^
>                                             %u
> 
> Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
> ---

Ugh, and I didn't test it ... libcflat doesn't support %z.
Casting the sizeof result to unsigned would work, but I don't like it
one bit.  Is there a convention in naming the conversion?  (like PRI...)

Thanks.