Re: [kvm-unit-tests PATCH v3 4/7] s390x: compile sclp-ascii.c

Thomas Huth
2017-05-22T09:47:45Z

On 22.05.2017 10:56, David Hildenbrand wrote:
> We can reuse strlen and memcpy. __pa(x) is already defined in page.h
> We don't have (and need) defines for error values and consuming sclp
> irqs is not required, as we won't be passing control to some other OS.
>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
> lib/s390x/sclp-ascii.c | 28 +++++++---------------------
> lib/s390x/sclp.h | 2 --
> s390x/Makefile | 1 +
> 3 files changed, 8 insertions(+), 23 deletions(-)

Reviewed-by: Thomas Huth <thuth@redhat.com>