From: Nick Desaulniers <nick.desaulniers@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Radim Krčmář" <rkrcmar@redhat.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] KVM: x86: avoid large stack allocations in em_fxrstor
Date: Wed, 31 May 2017 18:05:05 -0700 [thread overview]
Message-ID: <20170601010505.jl7dlat3zaaw6osf@lostoracle.net> (raw)
In-Reply-To: <1815926933.3699401.1496228489339.JavaMail.zimbra@redhat.com>
On Wed, May 31, 2017 at 07:01:29AM -0400, Paolo Bonzini wrote:
> > + size = offsetof(struct fxregs_state, xmm_space[16]);
> This still has the same issue (it should be multiplied by 4).
I'm still misunderstanding the math here.
Why multiplied by four, in this case? 8 * 16 / 4 is used in other cases.
Also, previously Radim wrote:
>> + size = offsetof(struct fxregs_state, xmm_space[8]);
> This should be the size of first 8 XMM registers, but xmm_space is of
> type u32, so the correct size is
> xmm_space[8 * 16/sizeof(*fx_state.xmm_space)].
So I think my calculation is off in xmm_offset still? Can we make use
of well-named variables, in place of these constants? Otherwise the math
is hard to follow.
> Thanks Nick for the patches and Radim for the reviews!
> Paolo
Thanks for the code review!
next prev parent reply other threads:[~2017-06-01 1:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 6:24 [PATCH] KVM: x86: dynamically allocate large struct in em_fxrstor Nick Desaulniers
2017-05-24 14:19 ` Radim Krčmář
2017-05-25 1:36 ` Nick Desaulniers
2017-05-25 14:07 ` Paolo Bonzini
2017-05-26 4:13 ` Nick Desaulniers
2017-05-26 7:18 ` Paolo Bonzini
2017-05-29 19:55 ` [PATCH v2] KVM: x86: avoid large stack allocations " Nick Desaulniers
2017-05-29 20:14 ` kbuild test robot
2017-05-29 20:29 ` Nick Desaulniers
2017-05-29 20:39 ` [PATCH v3] " Nick Desaulniers
2017-05-29 22:40 ` Nick Desaulniers
2017-05-29 22:48 ` [PATCH v4] " Nick Desaulniers
2017-05-30 10:15 ` Paolo Bonzini
2017-05-30 14:05 ` Radim Krčmář
2017-05-31 3:08 ` [PATCH v5] " Nick Desaulniers
2017-05-31 11:01 ` Paolo Bonzini
2017-06-01 1:05 ` Nick Desaulniers [this message]
2017-06-01 7:36 ` Paolo Bonzini
2017-06-02 2:10 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170601010505.jl7dlat3zaaw6osf@lostoracle.net \
--to=nick.desaulniers@gmail.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).