From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [PATCH kvm-unit-tests v2 0/2] arm/arm64: smp: on_cpu improvements Date: Wed, 7 Jun 2017 17:00:06 +0200 Message-ID: <20170607150006.GI28750@potion> References: <20170602153109.2904-1-drjones@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, pbonzini@redhat.com To: Andrew Jones Return-path: Received: from mx1.redhat.com ([209.132.183.28]:52784 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751367AbdFGPAS (ORCPT ); Wed, 7 Jun 2017 11:00:18 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A512F48F for ; Wed, 7 Jun 2017 15:00:12 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170602153109.2904-1-drjones@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: 2017-06-02 17:31+0200, Andrew Jones: > After posting on_cpu() support yesterday I thought of some potential > issues. > 1) cpu0 was the only cpu allowed to call on_cpus, and no cpu was > allowed to call on_cpu on cpu0 (as it'll never idle). > 2) deadlocks are easy with this idle state scheduling model, but > also easy to detect, so we should. > > v2: > - fix race in cpu_wait() by ordering set/check correctly Applied, thanks.