From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [PATCH] vfio: Use ERR_CAST() instead of open coding it
Date: Tue, 13 Jun 2017 09:30:50 -0600
Message-ID: <20170613093050.76c65d1a@w520.home>
References: <20170518073431.sc6x2at4n4j7hngu@mwanda>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, kernel-janitors@vger.kernel.org
To: Dan Carpenter <dan.carpenter@oracle.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:57990 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752673AbdFMPav (ORCPT <rfc822;kvm@vger.kernel.org>);
        Tue, 13 Jun 2017 11:30:51 -0400
In-Reply-To: <20170518073431.sc6x2at4n4j7hngu@mwanda>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, 18 May 2017 10:34:31 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:

> It's a small cleanup to use ERR_CAST() here.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c
> index 561084ab387f..6a49485eb49d 100644
> --- a/drivers/vfio/vfio.c
> +++ b/drivers/vfio/vfio.c
> @@ -382,7 +382,7 @@ static struct vfio_group *vfio_create_group(struct iommu_group *iommu_group)
>  	if (IS_ERR(dev)) {
>  		vfio_free_group_minor(minor);
>  		vfio_group_unlock_and_free(group);
> -		return (struct vfio_group *)dev; /* ERR_PTR */
> +		return ERR_CAST(dev);
>  	}
>  
>  	group->minor = minor;

Applied to next branch for v4.13, thanks Dan!

Alex