From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Roman Kagan <rkagan@virtuozzo.com>,
kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
Evgeny Yakovlev <eyakovlev@virtuozzo.com>,
"Denis V . Lunev" <den@openvz.org>
Subject: Re: [PATCH kvm-unit-tests 5/5] add hyperv_connections test
Date: Wed, 14 Jun 2017 14:59:51 +0200 [thread overview]
Message-ID: <20170614125951.GB2343@potion> (raw)
In-Reply-To: <20170614120103.GK2004@rkaganb.sw.ru>
2017-06-14 15:01+0300, Roman Kagan:
> On Tue, Jun 13, 2017 at 09:28:59PM +0200, Radim Krčmář wrote:
> > 2017-06-06 22:19+0300, Roman Kagan:
> > > Add a test for Hyper-V message and event connections.
> > >
> > > It requires QEMU with the extended test device supporting message end
> > > event connection test modes (recently posted on qemu-devel). On older
> > > QEMU versions it fails.
> >
> > Doesn't QEMU provide a way to detect this feature from the outside (some
> > command line magic) that we could use it to skip the test?
>
> I didn't know there was such a trick. However, I failed to figure out
> how to get it to work here: the -device options appeared to be
> interpreted after -kernel so it didn't cause a SKIP;
Hm, the test should be skipped if QEMU fails to start.
> adding a dedicated
> toplevel command-line option would probably be an overkill.
Right, I assumed that QEMU wants to prevent migration to QEMU's that
don't support this feature (which usually implies a property), but it
seems that there are no real users to care about ...
The solution proposed by Paolo looks good.
Thanks.
next prev parent reply other threads:[~2017-06-14 12:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 19:19 [PATCH kvm-unit-tests 0/5] add test for hyperv connections Roman Kagan
2017-06-06 19:19 ` [PATCH kvm-unit-tests 1/5] hyperv: move test dev control codes to C file Roman Kagan
2017-06-06 19:19 ` [PATCH kvm-unit-tests 2/5] hyperv: don't take vcpu where inappropriate Roman Kagan
2017-06-06 19:19 ` [PATCH kvm-unit-tests 3/5] hyperv: add more test control codes Roman Kagan
2017-06-06 19:19 ` [PATCH kvm-unit-tests 4/5] hyperv: add more hyperv definitions Roman Kagan
2017-06-06 19:19 ` [PATCH kvm-unit-tests 5/5] add hyperv_connections test Roman Kagan
2017-06-13 19:28 ` Radim Krčmář
2017-06-14 11:28 ` Paolo Bonzini
2017-06-14 12:02 ` Roman Kagan
2017-06-14 12:01 ` Roman Kagan
2017-06-14 12:59 ` Radim Krčmář [this message]
2017-06-14 13:21 ` Roman Kagan
2017-06-14 16:34 ` Radim Krčmář
2017-06-14 18:58 ` [PATCH kvm-unit-tests 0/5] add test for hyperv connections Radim Krčmář
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170614125951.GB2343@potion \
--to=rkrcmar@redhat.com \
--cc=den@openvz.org \
--cc=eyakovlev@virtuozzo.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkagan@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).