From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [PATCH kvm-unit-tests 5/5] add hyperv_connections test Date: Wed, 14 Jun 2017 14:59:51 +0200 Message-ID: <20170614125951.GB2343@potion> References: <20170606191959.16987-1-rkagan@virtuozzo.com> <20170606191959.16987-6-rkagan@virtuozzo.com> <20170613192858.GB1276@potion> <20170614120103.GK2004@rkaganb.sw.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit To: Roman Kagan , kvm@vger.kernel.org, Paolo Bonzini , Evgeny Yakovlev , "Denis V . Lunev" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:55050 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752106AbdFNM7z (ORCPT ); Wed, 14 Jun 2017 08:59:55 -0400 Content-Disposition: inline In-Reply-To: <20170614120103.GK2004@rkaganb.sw.ru> Sender: kvm-owner@vger.kernel.org List-ID: 2017-06-14 15:01+0300, Roman Kagan: > On Tue, Jun 13, 2017 at 09:28:59PM +0200, Radim Krčmář wrote: > > 2017-06-06 22:19+0300, Roman Kagan: > > > Add a test for Hyper-V message and event connections. > > > > > > It requires QEMU with the extended test device supporting message end > > > event connection test modes (recently posted on qemu-devel). On older > > > QEMU versions it fails. > > > > Doesn't QEMU provide a way to detect this feature from the outside (some > > command line magic) that we could use it to skip the test? > > I didn't know there was such a trick. However, I failed to figure out > how to get it to work here: the -device options appeared to be > interpreted after -kernel so it didn't cause a SKIP; Hm, the test should be skipped if QEMU fails to start. > adding a dedicated > toplevel command-line option would probably be an overkill. Right, I assumed that QEMU wants to prevent migration to QEMU's that don't support this feature (which usually implies a property), but it seems that there are no real users to care about ... The solution proposed by Paolo looks good. Thanks.