Re: [GIT PULL] Please pull my kvm-ppc-fixes branch

[Paul Mackerras <paulus@ozlabs.org>]

On Tue, Jun 20, 2017 at 05:17:01PM +0200, Radim Krčmář wrote:
> 2017-06-20 14:55+0200, Paolo Bonzini:
> > On 20/06/2017 14:39, Radim Krčmář wrote:
> > > 2017-06-20 14:30+1000, Paul Mackerras:
> > >> Paolo,
> > >>
> > >> Please do a pull from my kvm-ppc-fixes branch to get 6 commits that I
> > >> would like to have go into 4.12, because they fix problems that could
> > >> cause hangs or crashes in the host (the first and last commit, but
> > >> only on POWER9 systems), or they fix problems that could allow guests
> > >> to potentially affect or disrupt the execution of the controlling
> > >> userspace (the other four).  They are all marked to go to stable.
> > > 
> > > Pulled, but only locally at the moment -- would you like me to apply
> > > "[PATCH v2] KVM: MIPS: Fix maybe-uninitialized build failure" directly?
> > 
> > Why not, isn't the tree yours? :)
> 
> Right, and the arch doesn't even match ... let's forget I asked. :)
> 
> Pushed into kvm/master, thanks.

Thanks.

On a related note, we still have the warning in virt/kvm/kvm_main.c
for CONFIG_SMP=n builds about the variable 'wait' being unused in
kvm_make_all_cpus_request(), because smp_call_function_many() doesn't
reference its 'wait' argument for uniprocessor configs.

This then causes the build to fail on powerpc because kvm_main.c
actually gets compiled under arch/powerpc, and we use -Werror for
arch/powerpc by default.

Paolo posted a sketch of a patch to make smp_call_function_many be a
static inline instead of a macro on UP, but it wasn't quite right and
no-one sent it anywhere.  Paolo, if you're OK with me cleaning it up
and sending it on, I'll do that.

Paul.