From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, David Matlack <dmatlack@google.com>,
Peter Feiner <pfeiner@google.com>
Subject: Re: [kvm-unit-tests PATCH 2/3] x86/vmx: fix detection of unmapped PTE
Date: Mon, 3 Jul 2017 18:42:19 +0200 [thread overview]
Message-ID: <20170703164219.GA30880@potion> (raw)
In-Reply-To: <83f91b73-f0ae-3e78-fc90-a79fd31fd574@redhat.com>
2017-07-03 12:34+0200, Paolo Bonzini:
> On 30/06/2017 12:33, Paolo Bonzini wrote:
> > This breaks the vmx PML test:
> >
> > Test suite: PML
> > PASS: PML - Dirty GPA Logging
> > ERROR - unexpected stage, 2.
> > VMEXIT info:
> > vmexit reason = 18
> > exit qualification = 0
> > Bit 31 of reason = 0
> > guest_rip = 0x4049b3
> > RAX=0x149a000 RBX=0x3f8 RCX=0x184 RDX=0x3fd
> > RSP=0x46efcf RBP=0x46efdf RSI=0x41a8a3 RDI=0x41a8a3
> > R8 =0xa R9 =0x3f8 R10=0 R11=0
> > R12=0 R13=0 R14=0 R15=0
> >
> >
> > (should have been "PASS: PML Full Event"). I didn't investigate why.
>
> Hmm, actually it seems to come and go. I've applied patches 2 and 3 for
> now.
I had to use a different machine to reproduce ... with the patches, the
guest report() (probably) accesses 1 more page, which adds one entry to
PML and changes the progress of this pml_main loop:
while (vmx_get_test_stage() == 1) {
*((u32 *)data_page2) = 0x1;
if (count++ > PML_INDEX)
break;
vmcall();
}
Each cycle adds 4 entries to the PML and the extra entry makes the log
fill just before the vmcall. I don't think the one extra access is
something we need to tend to, so I'll send a fix for the PML test.
next prev parent reply other threads:[~2017-07-03 16:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 17:26 [kvm-unit-tests PATCH 0/3] x86/vmx: fix vmx_EPT_AD_* tests Radim Krčmář
2017-06-29 17:26 ` [kvm-unit-tests PATCH 1/3] x86/vmx: fix EPT - MMIO access Radim Krčmář
2017-06-29 17:34 ` Peter Feiner
2017-06-30 10:22 ` Paolo Bonzini
2017-07-03 17:13 ` Radim Krčmář
2017-07-03 17:28 ` Paolo Bonzini
2017-06-29 17:26 ` [kvm-unit-tests PATCH 2/3] x86/vmx: fix detection of unmapped PTE Radim Krčmář
2017-06-29 17:38 ` Peter Feiner
2017-06-30 10:33 ` Paolo Bonzini
2017-07-03 10:34 ` Paolo Bonzini
2017-07-03 16:42 ` Radim Krčmář [this message]
2017-06-29 17:26 ` [kvm-unit-tests PATCH 3/3] x86/vmx: get EPT at the last level Radim Krčmář
2017-06-29 17:51 ` Peter Feiner
2017-06-29 18:08 ` Radim Krčmář
2017-06-29 18:17 ` Peter Feiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170703164219.GA30880@potion \
--to=rkrcmar@redhat.com \
--cc=dmatlack@google.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=pfeiner@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox