From mboxrd@z Thu Jan  1 00:00:00 1970
From: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
Subject: Re: [kvm-unit-tests PATCH 1/3] x86/vmx: fix EPT - MMIO access
Date: Mon, 3 Jul 2017 19:13:44 +0200
Message-ID: <20170703171343.GB30880@potion>
References: <20170629172647.22188-1-rkrcmar@redhat.com>
 <20170629172647.22188-2-rkrcmar@redhat.com>
 <CAM3pwhGkt0GELd1xS1y9W5dW5En4Wf5AT5xy2YEGcos6jvQ0-g@mail.gmail.com>
 <a57760cd-0d9a-e85e-bed9-06385b65b1b8@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Peter Feiner <pfeiner@google.com>, kvm@vger.kernel.org,
        David Matlack <dmatlack@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:34650 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1755330AbdGCRNs (ORCPT <rfc822;kvm@vger.kernel.org>);
        Mon, 3 Jul 2017 13:13:48 -0400
Content-Disposition: inline
In-Reply-To: <a57760cd-0d9a-e85e-bed9-06385b65b1b8@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

2017-06-30 12:22+0200, Paolo Bonzini:
> On 29/06/2017 19:34, Peter Feiner wrote:
> > Reading the memory mapped page with x2apic is a bug.  Use the generic reader
> > instead.  An alternative would be to disable x2apic.
> 
> Disabling x2apic would test what the test is supposed to test. :)

We should still be doing the same --  we're interested in testing the
MMIO access from the guest, which is being done in ept_main().

ept_init_common() is used just to access the reference value and I think
that allowing x2APIC there gives us a bit more leeway,

thanks.