From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Denis Plotnikov <dplotnikov@virtuozzo.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com, den@virtuozzo.com,
rkagan@virtuozzo.com
Subject: Re: [RFC PATCH 2/2] KVM: x86: add support of kvm-clock stablity in L2
Date: Mon, 10 Jul 2017 15:25:27 +0200 [thread overview]
Message-ID: <20170710132526.GA28283@potion> (raw)
In-Reply-To: <1498647301-130851-3-git-send-email-dplotnikov@virtuozzo.com>
2017-06-28 13:55+0300, Denis Plotnikov:
> Get rid of complex shadow monotonic timekeeper support in KVM.
> Extend and use timekeeper infrastructure instead.
>
> Make kvm-clock stable in L2 using the changed timekeeper
I see this patch as two logical changes:
1) refactoring that drops host time caching (gtod)
2) stable kvmclock for L2 when L1 is using kvmclock
Doing it in two patches would definitely be nicer and would allow us to
focus on the (less controversial) L2 enablement.
About (1), the removed pvclock_gtod_notify() also verifid whether the
host is using TSC and disabled master clock otherwise. Other changes
don't explain why it's not needed anymore -- is it because any changes
that make TSC unusable would be caught elsewhere?
About (2), it seems that there is no event in case the kvmclock is not
reliable anymore. We probably don't need it now, but it would be good
to have it thought out -- would that use a new notifier?
Thanks.
next prev parent reply other threads:[~2017-07-10 13:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 10:54 [RFC PATCH 0/2] make L2 kvm-clock stable Denis Plotnikov
2017-06-28 10:55 ` [RFC PATCH 1/2] timekeeper: change interface of clocksource reding functions Denis Plotnikov
2017-07-10 13:00 ` Radim Krčmář
2017-07-21 14:00 ` Denis Plotnikov
2017-06-28 10:55 ` [RFC PATCH 2/2] KVM: x86: add support of kvm-clock stablity in L2 Denis Plotnikov
2017-07-10 13:25 ` Radim Krčmář [this message]
2017-07-10 13:32 ` Radim Krčmář
2017-07-21 14:01 ` Denis Plotnikov
2017-07-03 16:12 ` [RFC PATCH 0/2] make L2 kvm-clock stable Denis Plotnikov
2017-07-03 16:27 ` Paolo Bonzini
2017-07-10 7:56 ` Denis Plotnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170710132526.GA28283@potion \
--to=rkrcmar@redhat.com \
--cc=den@virtuozzo.com \
--cc=dplotnikov@virtuozzo.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkagan@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox