From: Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Claudio Imbrenda" <imbrenda@linux.vnet.ibm.com>,
"Dmitry V. Levin" <ldv@altlinux.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: s390: Fix KVM_S390_GET_CMMA_BITS ioctl definition
Date: Tue, 11 Jul 2017 00:23:21 +0300 [thread overview]
Message-ID: <20170710212321.GB2703@glebfm.cloud.tilaa.com> (raw)
In-Reply-To: <09c0760e-729d-548a-c3c4-b3afd9e67225@de.ibm.com>
On Mon, Jul 10, 2017 at 08:43:12PM +0200, Christian Borntraeger wrote:
> On 07/10/2017 04:44 PM, Gleb Fotengauer-Malinovskiy wrote:
> > This ioctl actually writes to parameter too.
>
> Maybe rephrase that to:
> The kernel does not only read struct kvm_s390_cmma_log for KVM_S390_GET_CMMA_BITS,
> it also writes back a return value making this _IOWR instead of _IOW.
Ok, see v2.
> > Fixes: 4036e387 ("KVM: s390: ioctls to get and set guest storage attributes")
> > Signed-off-by: Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org>
> Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
>
>
> Out of curiosity, how did you notice that?
I regenerated strace's ioctl lists. It was obvious from the diff that
*GET* and *SET* could not be both _IOC_WRITE.
--
glebfm
next prev parent reply other threads:[~2017-07-10 21:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-10 14:44 [PATCH] KVM: s390: Fix KVM_S390_GET_CMMA_BITS ioctl definition Gleb Fotengauer-Malinovskiy
2017-07-10 18:43 ` Christian Borntraeger
2017-07-10 21:22 ` [PATCH v2] " Gleb Fotengauer-Malinovskiy
2017-07-10 21:23 ` Gleb Fotengauer-Malinovskiy [this message]
2017-07-11 8:21 ` [PATCH] " Christian Borntraeger
2017-07-11 14:21 ` Radim Krčmář
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170710212321.GB2703@glebfm.cloud.tilaa.com \
--to=glebfm@altlinux.org \
--cc=borntraeger@de.ibm.com \
--cc=imbrenda@linux.vnet.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=ldv@altlinux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox