From: Christoffer Dall <christoffer.dall@linaro.org>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: "Christoffer Dall" <cdall@linaro.org>,
kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu,
"Andrew Jones" <drjones@redhat.com>,
"Alexander Graf" <agraf@suse.de>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Jintack Lim" <jintack@cs.columbia.edu>
Subject: Re: [PATCH kvm-unit-tests 1/3] arm64: timer: Fix vtimer interrupt test
Date: Fri, 14 Jul 2017 08:43:55 -0700 [thread overview]
Message-ID: <20170714154355.GB1535@lvm> (raw)
In-Reply-To: <a9e2f409-2188-2fbb-3ae6-ea8515fe8758@arm.com>
On Fri, Jul 14, 2017 at 08:55:32AM +0100, Marc Zyngier wrote:
> On 13/07/17 20:20, Christoffer Dall wrote:
> > The timer irq_handler is supposed to mask the timer signal, but unfortunately
> > also disables the timer at the same time, even though we loop and wait on
> > ISTATUS to become set.
> >
> > According to the ARM ARM, "When the value of the ENABLE bit is 0, the
> > ISTATUS field is UNKNOWN." This test happens to work on AMD Seattle, but
> > doesn't work on Mustang or on QEMU with TCG.
>
> Note that this wording is a tightening of what was written in previous
> of the ARMv8 ARM. Version DDI0874B.a has the above, while DDI0487A.h
> doesn't, neither has the ARMv7 version.
>
> This may explain why this was initially written this way.
>
ok, but even so, this patch should test things in a way that should work
on all systems, right?
Thanks,
-Christoffer
next prev parent reply other threads:[~2017-07-14 15:44 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 19:20 [PATCH kvm-unit-tests 0/3] Add physical timer test Christoffer Dall
2017-07-13 19:20 ` [PATCH kvm-unit-tests 1/3] arm64: timer: Fix vtimer interrupt test Christoffer Dall
2017-07-14 7:55 ` Marc Zyngier
2017-07-14 15:43 ` Christoffer Dall [this message]
2017-07-14 15:54 ` Marc Zyngier
2017-07-13 19:20 ` [PATCH kvm-unit-tests 2/3] arm64: timer: Fix test on APM X-Gene Christoffer Dall
2017-07-14 8:04 ` Marc Zyngier
2017-07-14 15:45 ` Christoffer Dall
2017-07-18 10:05 ` Andrew Jones
2017-07-18 10:35 ` Christoffer Dall
2017-07-18 12:15 ` Andrew Jones
2017-07-24 17:13 ` Paolo Bonzini
2017-07-24 21:25 ` Christoffer Dall
2017-07-26 11:38 ` Christoffer Dall
2017-07-13 19:20 ` [PATCH kvm-unit-tests 3/3] arm64: timer: Add support for phys timer testing Christoffer Dall
2017-07-18 12:09 ` Andrew Jones
2017-07-18 13:01 ` Christoffer Dall
2017-07-18 13:23 ` Andrew Jones
2017-07-18 13:31 ` Christoffer Dall
2017-07-18 13:50 ` Andrew Jones
2017-07-18 14:15 ` Christoffer Dall
2017-07-18 14:29 ` Andrew Jones
2017-07-18 14:37 ` Christoffer Dall
2017-07-18 10:17 ` [PATCH kvm-unit-tests 0/3] Add physical timer test Andrew Jones
2017-07-18 10:42 ` Christoffer Dall
2017-07-18 12:20 ` Andrew Jones
2017-07-24 17:16 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170714154355.GB1535@lvm \
--to=christoffer.dall@linaro.org \
--cc=agraf@suse.de \
--cc=cdall@linaro.org \
--cc=drjones@redhat.com \
--cc=jintack@cs.columbia.edu \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=marc.zyngier@arm.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox