From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoffer Dall Subject: Re: [PATCH kvm-unit-tests 1/3] arm64: timer: Fix vtimer interrupt test Date: Fri, 14 Jul 2017 08:43:55 -0700 Message-ID: <20170714154355.GB1535@lvm> References: <20170713192009.10069-1-cdall@linaro.org> <20170713192009.10069-2-cdall@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoffer Dall , kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, Andrew Jones , Alexander Graf , Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= , Jintack Lim To: Marc Zyngier Return-path: Received: from mail-lf0-f54.google.com ([209.85.215.54]:35444 "EHLO mail-lf0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754051AbdGNPoC (ORCPT ); Fri, 14 Jul 2017 11:44:02 -0400 Received: by mail-lf0-f54.google.com with SMTP id b207so55850286lfg.2 for ; Fri, 14 Jul 2017 08:44:02 -0700 (PDT) Content-Disposition: inline In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Jul 14, 2017 at 08:55:32AM +0100, Marc Zyngier wrote: > On 13/07/17 20:20, Christoffer Dall wrote: > > The timer irq_handler is supposed to mask the timer signal, but unfortunately > > also disables the timer at the same time, even though we loop and wait on > > ISTATUS to become set. > > > > According to the ARM ARM, "When the value of the ENABLE bit is 0, the > > ISTATUS field is UNKNOWN." This test happens to work on AMD Seattle, but > > doesn't work on Mustang or on QEMU with TCG. > > Note that this wording is a tightening of what was written in previous > of the ARMv8 ARM. Version DDI0874B.a has the above, while DDI0487A.h > doesn't, neither has the ARMv7 version. > > This may explain why this was initially written this way. > ok, but even so, this patch should test things in a way that should work on all systems, right? Thanks, -Christoffer